Skip to content

Feat: Detect if a Next.js project is running on the specified port before opening a tunnel #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-aitken merged 4 commits into from
Jul 31, 2023
Merged

Feat: Detect if a Next.js project is running on the specified port before opening a tunnel #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8f2821
Feat: Detect nextjs project
Ashutosh-Bhadauriya Jul 25, 2023
fe6913e
Add check before opening tunnel
Ashutosh-Bhadauriya Jul 25, 2023
2c38436
Update dev.ts
Ashutosh-Bhadauriya Jul 26, 2023
f006d67
Add changeset
Ashutosh-Bhadauriya Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blue-monkeys-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/cli": patch
---

Detect if a nextjs project is running on the specified port before opening tunnel
20 changes: 18 additions & 2 deletions packages/cli/src/commands/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { logger } from "../utils/logger.js";
import { resolvePath } from "../utils/parseNameAndPath.js";
import { TriggerApi } from "../utils/triggerApi.js";
import dotenv from "dotenv";
import fetch from "node-fetch";

export const DevCommandOptionsSchema = z.object({
port: z.coerce.number(),
Expand Down Expand Up @@ -48,7 +49,7 @@ export async function devCommand(path: string, anyOptions: any) {
logger.success(`✔️ [trigger.dev] Detected TriggerClient id: ${endpointId}`);

// Read from .env.local or .env to get the TRIGGER_API_KEY and TRIGGER_API_URL
const { apiUrl, envFile } = await getTriggerApiDetails(
const { apiUrl, envFile, apiKey } = await getTriggerApiDetails(
resolvedPath,
options.envFile
);
Expand All @@ -59,9 +60,24 @@ export async function devCommand(path: string, anyOptions: any) {
` [trigger.dev] Looking for Next.js site on port ${options.port}`
);

const localEndpointHandlerUrl = `http://localhost:${options.port}${options.handlerPath}`;

try {
await fetch(localEndpointHandlerUrl, {
method: "HEAD",
headers: {
"x-trigger-api-key": apiKey,
"x-trigger-action": "PING",
"x-trigger-endpoint-id": endpointId,
},
});
} catch (err) {
logger.error(`❌ [trigger.dev] No server found on port ${options.port}.`);
process.exit(1);
}

// Setup tunnel
const endpointUrl = await resolveEndpointUrl(apiUrl, options.port);

const endpointHandlerUrl = `${endpointUrl}${options.handlerPath}`;

const connectingSpinner = ora(
Expand Down