Skip to content

[TRI-1178] stripe.onAccountUpdated only works if you pass { connect: true } #424

Closed

Description

@matt-aitken

onAccountUpdated is a Stripe Connect event, and only works when that's specified. We need to update our code so the default is true for connect.

If you're encountering this issue, you can fix it by doing this:

stripe.onAccountUpdated({ connect: true })

We need to fix it in the integration package so it's not required to pass that option.

From SyncLinear.com | TRI-1178

Activity

  1. OshriAsulin commented on Aug 30, 2023

    @OshriAsulin

    Hello @matt-aitken , I want to work on this issue.
    Can you explain me where is exist the integration package?

  2. RamK777-stack commented on Sep 1, 2023

    @RamK777-stack
    Contributor

    @matt-aitken Initially we passed connect as false by default in this function
    createTrigger(this.source, events.onAccountUpdated, params ?? { connect: false })

    So changing this to connect: true will suffice?

  3. matt-aitken commented on Oct 2, 2023

    @matt-aitken
    MemberAuthor

    @RamK777-stack sorry I realised I never responded to this. I actually did exactly the change you suggest above in a different integrations PR. SO I'm going to close this.

  4. added this to the v.14 milestone on Oct 2, 2023
  5. RamK777-stack commented on Oct 3, 2023

    @RamK777-stack
    Contributor

    Okay no problem, thanks @matt-aitken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions