Add ssl option to RemoteDatabaseConfig#1690
Merged
yoyama merged 5 commits intotreasure-data:masterfrom Jul 29, 2022
gumigumi4f:master
Merged
Add ssl option to RemoteDatabaseConfig#1690yoyama merged 5 commits intotreasure-data:masterfrom gumigumi4f:master
yoyama merged 5 commits intotreasure-data:masterfrom
gumigumi4f:master
Conversation
Contributor
|
@gumigumi4f Thank you for your contribution. |
yoyama
requested changes
Apr 18, 2022
Contributor
yoyama
left a comment
There was a problem hiding this comment.
As comment, please update document.
Contributor
Author
|
Sorry for late response. |
yoyama
reviewed
Jul 5, 2022
yoyama
reviewed
Jul 5, 2022
yoyama
reviewed
Jul 5, 2022
Contributor
Author
|
I have updated the docs. |
Contributor
|
Thank you for your contribution. After CI has passed, I will approve it. |
yoyama
approved these changes
Jul 29, 2022
Contributor
yoyama
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to connect background postgresql database with server and client certificates. (Ex: Google Cloud SQL)
But there is no option to change sslfactory and sslmode and we cannot connect database.
After merging this PR, we are able to connect postgresql with certificates by adding the following settings and placing the certificates to
${user.home}/.postgresql/.