Skip to content

safeTransferFrom fails on a transfer to a BeaconProxy, but works with OZ's safeTransferFrom #370

Description

@0xTimepunk

As the title implies, a safeTransferFrom using solmate's ERC20 & SafeTransferLib fails when transferring any amount to a OpenZeppelin BeaconProxy contract (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/proxy/beacon/BeaconProxy.sol)

Using OpenZeppelins' safeTransfer library, together with their ERC20, works for the exact same call and amount.

To reproduce, just deploy a BeaconProxy attached to an implementation contract and run a safeTransferFrom in the contract.

Activity

  1. androolloyd commented on Apr 17, 2023

    @androolloyd

    submit a reproduction repo plz, this is likely an issue with your setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions