This repository was archived by the owner on Jul 13, 2019. It is now read-only.
Using namespace literals#16
Closed
tkruse wants to merge 2 commits into
Closed
Conversation
18 tasks
tkruse
force-pushed
the
using-namespace-literals
branch
from
45af294 to
67e5002
Compare
Owner
Author
|
manually merged |
Owner
Author
|
Given the response on google/styleguide#92, I wonder fi we should revert this change, or treat it differently. @mattyclarkson, possibly literal namespaces could be guarded by a different rule, so you could switch off checking of literal namespaces, but keep the checks of other namespaces. What do you think? |
Closed
Owner
Author
|
Created #28 for redesigning |
|
@tkruse, sure. It would make sense to have it under a seperate rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.