Repository navigation
Fix: q weight on Accept/Content-Type wrongly treated as a media type parameter - #129
Merged
Merged
Conversation
…parameter RFC 9110 §12.4.2: q terminates a media type's parameter list — it and everything after it are accept-extension parameters belonging to the header field, not the media type. JSON:API §5's ext/profile whitelist governs only the media type's own parameters, so q must not count against it. parseMediaType now splits positionally: parameters before q are checked against the ext/profile whitelist as before; q itself and any parameter after it are stripped and never checked. acceptIsAcceptable also treats a q=0 entry as an explicit refusal rather than a malformed parameter, so it's skipped rather than rejected for the wrong reason. Fixes #101. Two existing tests (src/Atomic.test.ts, examples/blog/test/blog.test.ts) asserted the old buggy behavior for q and are updated to match the corrected semantics. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YRZS52nrSowy8EphoU5rbJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 §12.4.2: q terminates a media type's parameter list — it and
everything after it are accept-extension parameters belonging to the
header field, not the media type. JSON:API §5's ext/profile whitelist
governs only the media type's own parameters, so q must not count
against it.
parseMediaType now splits positionally: parameters before q are checked
against the ext/profile whitelist as before; q itself and any parameter
after it are stripped and never checked. acceptIsAcceptable also treats
a q=0 entry as an explicit refusal rather than a malformed parameter,
so it's skipped rather than rejected for the wrong reason.
Fixes #101. Two existing tests (src/Atomic.test.ts,
examples/blog/test/blog.test.ts) asserted the old buggy behavior for
q and are updated to match the corrected semantics.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01YRZS52nrSowy8EphoU5rbJ