Skip to content

feat(Conformance): leave the #278 include / sort refusal rules not decided on a probe that says nothing #352

Closed

Description

@thomasfosterau

Found while implementing #310.

Problem

The two #278 refusal rules (spec/query/include-unsupported-endpoint, spec/query/sort-unsupported-endpoint) and the seven #310 rules now share one probe driver (probeFirstUsable in src/internal/conformance/spec.ts), but they treat a probe that says nothing differently:

#310 kept the #278 behaviour (unanswered: "finding") so that it would not change existing rules' outcomes outside its scope.

Proposal

Switch the two #278 rules to unanswered: "undecided". This is a one-line change per rule, plus updates to the pinned test and to the docs/conformance.md sentence that names the difference.

This is an owner decision: should a 500 for ?include= on an endpoint that does not support it be a failure (the server did not answer 400) or not decided (the server's answer says nothing)?

Done when


Generated by Claude Code

Activity

  1. thomasfosterau commented on Oct 15, 2026

    @thomasfosterau
    OwnerAuthor

    Owner decision, 2026-10-15 (session chat): a 5xx is a finding; 429, 408 and a lost response are not decided.

    This applies to all nine refusal rules that share probeFirstUsable, so they stay consistent: the two from #278 and the seven from #310.

    • 5xx: a server that answers 5xx to an unsupported parameter mishandled it. The rule fails.
    • 429, 408, lost response: these say nothing about whether the parameter is refused. The rule is Skipped, with a reason.

    For the #310 rules this is a change: they currently leave a 5xx not decided. The changeset should say so.

    This is queued behind PR #366, because both touch the kit's tests and docs/conformance.md.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions