Skip to content

Supported Node range: engines says >=22, CI and the ruleset require 20.x #200

Closed

Description

@thomasfosterau

Found while working #199 (decision D-1, owner accepted the reviewer's recommendation; the fix is config, not docs, so it lands here rather than in the docs PR).

The inconsistency. The published package.json declares engines.node: ">=22", and README.md says "Node.js 22 or newer is required". But .github/workflows/ci.yml runs every gate on a 20.x matrix row as well as 22.x, and the main ruleset requires the Lint, type-check, build & test (20.x) check. So CI proves Node 20 works while the package tells consumers on 20 it is unsupported (they get engine warnings, or failures under engine-strict).

Options (from #199):

  • (a) Support Node 20 for consumers: relax engines to >=20 (installing and bundling still need 22, which CI already handles by building on 22 before switching to the matrix Node), and have the README say "runs on Node 20+; developing needs 22". Recommended if any consumer still runs Node 20 (Cloudflare Workers are unaffected either way).
  • (b) Drop 20.x from the CI matrix and from the main ruleset's required checks, keeping >=22.

Done when engines, the CI matrix, the ruleset's required checks and the README's Install line all state the same supported range. A change to engines is a published-behaviour change and needs a changeset.


Generated by Claude Code

Activity

  1. thomasfosterau commented on Oct 8, 2026

    @thomasfosterau
    OwnerAuthor

    Triage, 2026-10-08: the premise of this issue no longer holds on trunk (0f8bdda).

    • ci: test on the latest stable Node only #211 (closed 2026-10-03, owner decision) collapsed CI to one job on node-version: latest (.github/actions/setup/action.yml, header comment in .github/workflows/ci.yml). No workflow pins 20.x any more, and the Default ruleset requires only Lint, type-check, build & test.
    • ci: test on the latest stable Node only #211 also said to leave engines.node unchanged. It is still ">=22" in package.json, which agrees with README.md ("Node.js 22 or newer") and CONTRIBUTING.md ("Node.js 22 or higher").

    So the intended range is >=22, and nothing contradicts it now. The only open question is whether CI should also test the engines floor (22) as well as latest. That, and whether to close this as resolved by #211, is the owner's call.


    Generated by Claude Code

  2. thomasfosterau commented on Oct 21, 2026

    @thomasfosterau
    OwnerAuthor

    Owner decision (2026-10-21): closing as resolved by #211. engines.node >=22, README and CONTRIBUTING agree, and CI runs latest only; no separate floor job.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions