Repository navigation
topology1: add support for cs42l42-sdw - #8370
davidrau-renesas-opensource wants to merge 1 commit into
Conversation
Adding support for cs42l42 via SoundWire Signed-off-by: David Rau <David.Rau.opensource@dm.renesas.com>
|
Can one of the admins verify this patch?
|
|
test this please
|
1 similar comment
|
test this please |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks you @davidrau-renesas-opensource for the submission. One minor note, but a bigger ask is that can you submit this against the stable-v2.2 branch (make a pull-request to this branch). We have dropped topology1 support for Intel platforms from SOF mainline, and support for topology1 TGL/ADL platforms is now done in the stable-v2.2 branch.
| @@ -0,0 +1,286 @@ | |||
| # | |||
| # Topology for Tigerlake with rt711 + rt1308 (x2). | |||
There was a problem hiding this comment.
This comment needs to be updated.
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Blocking with "request changes" until we agree about what's missing in existing topologies first.
| # | ||
| # Topology for Tigerlake with rt711 + rt1308 (x2). | ||
| # | ||
|
|
There was a problem hiding this comment.
why is there a need to create a new topology just to support a new headset codec?
Put differently, why not use the existing topology or describe what's missing?
Topology files are a PITA to maintain, less is more really.
There was a problem hiding this comment.
Thanks for the suggestions.
These modifications I did is a temproary solution to enable CS42L42 codec in ADL platform.
Topology files are a PITA to maintain, less is more really.
Agreed with you. :)
|
|
||
| # PCM Low Latency, id 0 | ||
| dnl PCM_PLAYBACK_ADD(name, pcm_id, playback) | ||
| PCM_PLAYBACK_ADD(CS42L42 Jack Out, 0, PIPELINE_PCM_30) |
There was a problem hiding this comment.
why redefine names? What was wrong with just 'Jack Out' which is used by all existing solutions?
There was a problem hiding this comment.
Understood.
|
@davidrau-renesas-opensource it wouldn't hurt if you introduced a bit more the problem you are trying to solve and in which environment. We are not really aware of any ADL platform based on CS42L42? |
Here is the story. After such modificatins, I can verify the playback function and then push this tplg file that the maintainer asked. |
|
Glad its working for you now @davidrau-renesas-opensource, did you say what SOF version you are using? Is it v2.2 with IPC3 or v2.3+ with IPC4 ? as this determines what we need to upstream as some features are being deprecated. Thanks |
@lgirdwood And I clone SOF repository from your Github to create this tplg source file for CS42L42. Thanks. |
|
@davidrau-renesas-opensource Can you submit a pull req with this commit o stable-v2.2 branch? It has the latest tools/topology1 so this PR should apply cleanly on top of it. |
@kv2019i Thanks for your suggestions. :) |
5 participants
Adding support for cs42l42 via SoundWire