Repository navigation
copier: fix no consume for multi endpoint copy - #7987
Merged
Merged
Conversation
btian1
force-pushed
the
fix_multiend_consume
branch
from
July 27, 2023 07:58
b6e0bc7 to
4b328b2
Compare
btian1
changed the title
btian1
marked this pull request as ready for review
July 27, 2023 07:58
btian1
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
July 27, 2023 07:58
ranj063
approved these changes
Jul 27, 2023
RanderWang
reviewed
Jul 28, 2023
Collaborator
There was a problem hiding this comment.
if (!ret)
comp_update_buffer_consume(src_c, processed_data.source_bytes);
btian1
force-pushed
the
fix_multiend_consume
branch
from
July 28, 2023 09:57
4b328b2 to
af2cf01
Compare
lyakh
reviewed
Jul 28, 2023
btian1
force-pushed
the
fix_multiend_consume
branch
from
July 28, 2023 12:43
af2cf01 to
57c757f
Compare
Collaborator
|
Small improvement suggestion: In the commit message, Please also add |
btian1
force-pushed
the
fix_multiend_consume
branch
from
July 31, 2023 05:53
57c757f to
fec2c8b
Compare
In last time copier code split, it split multi-endpoint copy and module copy with commit: e424b87, source buffer consume was missed, added it back with this PR. Fixes:thesofproject#7979 Signed-off-by: Baofeng Tian <baofeng.tian@intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
lgirdwood
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In last time copier code split, it split multi-endpoint copy and module copy with commit: e424b87, source buffer consume was missed, added it back with this PR.
Fixes:#7979