Repository navigation
Conversation
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Too much duplication for just 2 SSPs added.
There was a problem hiding this comment.
no, that's too much duplication and it's unmaintainable.
I would recommend using the same sof-glk-es8336 and conditionally include an 'hdmi-in.m4' in which you can add your own stuff.
There was a problem hiding this comment.
lines 161 to here go to hdmi-in.m4
There was a problem hiding this comment.
lines 212-213 go to hdmi-in.m4
There was a problem hiding this comment.
line 230 to here go to hdmi-in.m4
You will need to add defines for SSP0 and SSP2 so that there's no conflict should the primary SSP_NUM change.
|
Was this PR close accidental or intentional? If accidental I'd recommend creating a new pull request on a branch of yours other than "main" to avoid this happening again. |
|
due to rebase issue , the review comments are addressed in new PR. #6299. PR was closed intentional due to fork repo sync with this repo. |
3 participants
ADL support for ES83x6 codec alone and ADL support for ES83x6+HDMI_in support