Repository navigation
.github: add shallow checkpatch to Github Actions - #3899
Merged
Merged
Conversation
Let's try to run checkpatch in an open-source and fast way while leveraging Github's very good user interface. Run checkpatch both with and without --strict; this has been a source of confusion in the past, see thesofproject/linux#1988 Note this attempt does not rely on git merge-bases which has been found to be not compatible with shallow cloning: thesofproject/linux#2556 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
March 4, 2021 20:21
marc-hb
requested review from
cujomalainey,
dbaluta,
lgirdwood,
xiulipan and
zrombel
as code owners
March 4, 2021 20:21
marc-hb
requested review from
aiChaoSONG,
fredoh9,
kv2019i,
lyakh,
paulstelian97,
plbossart and
ranj063
March 4, 2021 20:22
lgirdwood
approved these changes
Mar 4, 2021
Member
|
@marc-hb can you check CI - I assume you expect checkpatch to fail here ? |
Collaborator
Author
|
https://github.com/thesofproject/sof/pull/3899/checks?check_run_id=2034401175 completed in 13 seconds whereas https://sof-ci.01.org/sofpr/PR3899/build8256/checkpatch/ took more than 2 minutes to complete (probably because of GH polling for the most part) This one shows complete logs and the implementation can be accessed and maintained by anyone outside Intel. It runs both --strict and not.
I typically spell "check-patch" to dodge that warning but in this case I left it for demo purposes. |
aiChaoSONG
approved these changes
Mar 5, 2021
paulstelian97
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's try to run checkpatch in an open-source and fast way while
leveraging Github's very good user interface.
Run checkpatch both with and without --strict; this has been a source of
confusion in the past, see
thesofproject/linux#1988
Note this attempt does not rely on git merge-bases which has been found
to be not compatible with shallow cloning:
thesofproject/linux#2556
Signed-off-by: Marc Herbert marc.herbert@intel.com