Repository navigation
rimage: support for custom imr type - #1258
Merged
Merged
Conversation
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
tlauda
approved these changes
Apr 11, 2019
xiulipan
reviewed
Apr 11, 2019
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Codec look good. But I have some question about why we need this.
What should be the legal value or IMR_TYPE? Should we check that inside rimage?
Should we use some macro or enum to represent the types?
mmaka1
approved these changes
Apr 11, 2019
mmaka1
approved these changes
Apr 11, 2019
mmaka1
approved these changes
Apr 11, 2019
Contributor
Author
|
@xiulipan It's enum value that is understood by rom?/cse and indicates type of IMR, but idk if it is somehow standarized or any vendor can have any value. As you could see earlier 3 was for our RVPs, other values may be used for other hardware, but idk if we should have defines for that available in public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds
RIMAGE_IMR_TYPEcmake's variable and-i <int>arg to rimage.We need it to change imr type f.e. for some production platforms.