Skip to content

CMake/rimage: add option to use out-of-tree private key - #1248

Merged
tlauda merged 1 commit into
thesofproject:masterfrom
plbossart:fix/private-key
Apr 10, 2019
Merged

tlauda merged 1 commit into
thesofproject:masterfrom
plbossart:fix/private-key

Conversation

@plbossart

Copy link
Copy Markdown
Member

On specific Intel platforms, we have to use a private key which is not
shared with the rest of the world.

Extended xtensa-build-all.sh with an option, and pass the key path
explicitly to cmake.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@jajanusz jajanusz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor issue related to default value. Also I'll close #1239 #1240 if this one is going to be merged

Comment thread src/arch/xtensa/CMakeLists.txt Outdated
Comment thread scripts/xtensa-build-all.sh Outdated
On specific Intel platforms, we have to use a private key which is not
shared with the rest of the world.

Extend xtensa-build-all.sh with an option, and pass the key path
explicitly to cmake if needed.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
plbossart requested a review from jajanusz April 9, 2019 21:54

@jajanusz jajanusz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@xiulipan

Copy link
Copy Markdown
Contributor

SOFCI TEST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants