Repository navigation
case-lib: add an option to control fallback behavior - #914
Merged
Merged
Conversation
Previously, if SOF card is not detected from the system, we will export pipelines from proc file system, this is good for legacy HDA test, but for SOF test, this causes false positive because usually under this condition, we are testing USB sound card or Nvidia HDMI. This patch adds an option to control the fallback behavior, It should be set to 'false' for SOF test, and set to 'true' for legacy HDA test. Signed-off-by: Chao Song <chao.song@linux.intel.com>
marc-hb
approved these changes
May 27, 2022
marc-hb
left a comment
marc-hb
left a comment
Collaborator
There was a problem hiding this comment.
I would prefer new modes like "TEST_HDA" or "TEST_USB" but it would be much work, this is quick and simple and gets the job done without too much technical debt. Thx for the quick fix!
keqiaozhang
approved these changes
May 27, 2022
plbossart
approved these changes
May 31, 2022
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
Ideally we would have a more explicit parameter to e.g. test on USB only or NVIDIA only, but this is good enough for our own tests.
Thanks @aiChaoSONG !
Author
|
The new env is setup on our two RKL devices, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if SOF card is not detected from the system,
we will export pipelines from proc file system, this is
good for legacy HDA test, but for SOF test, this causes
false positive because usually under this condition, we
are testing USB sound card or Nvidia HDMI.
This patch adds an option to control the fallback behavior,
It should be set to 'false' for SOF test, and set to 'true'
for legacy HDA test.
Signed-off-by: Chao Song chao.song@linux.intel.com