Repository navigation
pipeline: fix misleading pipeline exporting info - #359
Merged
Merged
Conversation
marc-hb
requested changes
Sep 2, 2020
| # got tplg_file, verify file exist | ||
| tplg_path=$(func_lib_get_tplg_path "$1") || { | ||
| die "No available topology for pipeline export" | ||
| die "No topology found! Please configure TPLG env to point to you topology path." |
Collaborator
There was a problem hiding this comment.
Many tests seem to have a -t option so setting TPLG is not the only possible solution.
It looks like this new error message will ask me to set TPLG even when I make a typo in TPLG. That's confusing. It will also not show my typo.
How about:
die "Topology $1 not found, check the TPLG environment variable"
Author
There was a problem hiding this comment.
@marc-hb The default value for -t option is $TPLG. if No TPLG is set, and -t not specified, the "$1" will be empty. How about this: Topology not found, check TPLG environment variable or specify topology path with -t
Collaborator
There was a problem hiding this comment.
- if
$1is empty:Topology not found, check TPLG - if
$1is wrong:Topology wrong_file not found, check TPLG.
I don't mind mentioning -t in the message but it should also print $1.
Author
There was a problem hiding this comment.
I'd like the -t in the message, updated
aiChaoSONG
force-pushed
the
fix_unclear_info
branch
from
September 3, 2020 06:44
7c80571 to
71d1bec
Compare
The "No available topology ..." info is misleading, this patch makes it clearer. Fixes: thesofproject#232 Signed-off-by: Amery Song <chao.song@intel.com>
marc-hb
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "No available topology ..." info is misleading,
this patch makes it clearer.
Fixes: #232
Signed-off-by: Amery Song chao.song@intel.com