Skip to content

[BUG] Remove buffer core ID from topology viewer #925

Description

@ranj063

Describe the bug
Buffer's are shown to be on Core: 0 in the topology viewer. They are passive components and do not have a core associated with them. It is confusing for people to see buffers and components in the same pipeline to have different core ID's

To Reproduce
Just view the topology graph for the sof-cavs-nocodec.tplg
https://sof-ci.01.org/sofpr/PR5958/build751/devicetest/?model=ADLP_RVP_NOCODEC&testcase=check-playback-10sec

Expected behavior
Buffers show no core ID

Activity

  1. miRoox commented on Jul 1, 2022

    @miRoox
    Contributor

    I think it's because those buffer components (like BUF7.0, BUF11.0, etc.) actually contain the element with token SOF_TKN_COMP_CORE_ID. If the component doesn't contain the core ID data, the graph won't show it, like BUF1.0, BUF2.1, etc. Therefore, I think the better way is to remove the core ID data from buffer components.

    It seems there are some historic reasons to allocate buffers on core 0 thesofproject/sof#5097. If it's unacceptable to remove buffer core ID from the source code, I can add an exception for the buffer components in the topology graph.

  2. added
    type:bugSomething doesn't work as expected
    and removed on May 17, 2023
  3. marc-hb commented on Jun 22, 2023

    @marc-hb
    Collaborator
  4. added
    P3Low-impact bugs or features
    on Jun 22, 2023
  5. marc-hb commented on Aug 13, 2024

    @marc-hb
    Collaborator

    @ranj063 is this still an issue? If yes can you share a link to a more recent example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Low-impact bugs or featurestype:bugSomething doesn't work as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions