Repository navigation
Trace test is reporting incorrect test results. #167
Description
The trace test is to test that the trace output is working. i.e. that DMA trace has valid trace data.
The trace test currently parses the trace data for "error" and reports any "error" strings found as a test fail. This is wrong. This test must not parse the trace log for "error" as it reporting failed trace functionality due to "error" strings in the trace output.
Parsing for "error" is valid for other tests but not this one.
Activity
aiChaoSONG commentedon Apr 3, 2020
There is already a fix #161
marc-hb commentedon Apr 27, 2020
Can someone copy an example?
Parsing should always be avoided when possible. I'm not familiar with this test suite yet but in general searching for kernel errors can be done with just one line:
and for warnings:
aiChaoSONG commentedon Apr 27, 2020
This issue is already fixed, we are not detecting error from firmware log anymore.
@marc-hb sorry for misleading you here. the firmware log is not in dmesg, it is extract by sof-logger.
marc-hb commentedon Apr 23, 2021
Too bad no other test does this.
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs