Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
dotenv runhandles missing commands cleanly, but a non-executable file or directory raises an uncaught PermissionError.Change: catch PermissionError in the POSIX execvpe and Windows Popen paths, print "Permission denied: " to stderr, and exit with status 1. Other launch errors keep their current behavior.
Tests: four new regressions fail before the fix and pass after it. Real POSIX subprocess checks cover a non-executable file and a directory; mocked checks cover both platform branches. Native Windows was not tested. Full suite: 294 passed, with 32 existing Click deprecation warnings. Ruff and changed-file formatting pass.
The full run used a controlled PATH because the inherited PATH contained an inaccessible directory. The same missing-command test failed on unchanged upstream with that PATH; no upstream test was changed.
AI-assisted implementation and testing.