feat: add opt-in $(command) substitution for .env values - #685
Open
kavin0x wants to merge 2 commits into
Open
Conversation
Enable shell command substitution via execute_commands=True on load_dotenv() and dotenv_values(), or --execute-commands on the CLI, so trusted .env files can populate variables from command output like gh auth token. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the gh auth token integration test that fails on unauthenticated runners, skip POSIX shell env expansion on Windows, and use python --version instead of printenv --version in CLI flag tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds optional command substitution for
.envvalues using shell-style$(command)syntax — useful for things like pulling a token at load time:GITHUB_TOKEN=$(gh auth token)It's off by default. Enable it with
execute_commands=Trueonload_dotenv()/dotenv_values(), or--execute-commandson the CLI (list,get,run).Resolution happens after normal
${VAR}interpolation, so mixed values likePREFIX=${BASE}-$(echo suffix)work as expected. Failed commands log a warning and resolve to an empty string.Test plan
uv run pytest— all feature tests pass (273+ passing locally)$(whoami),$(echo ...),${VAR}+$(cmd)combos, and$(gh auth token)with real subprocessesexecute_commands=Falseleaves$(...)literal)--execute-commandscovered in testsNotes
)inside$(...)aren't supported (documented in README).envfiles since commands run with the current process permissionsDisclaimer: AI tools were used to help with parts of the implementation and tests, but I reviewed everything before pushing.
Made with Cursor