Refactor failIf to assertFalse for Python 3.12 Compatibility#15
Merged
cjwatson merged 1 commit intotesting-cabal:masterfrom May 31, 2023
Merged
Refactor failIf to assertFalse for Python 3.12 Compatibility#15cjwatson merged 1 commit intotesting-cabal:masterfrom
cjwatson merged 1 commit intotesting-cabal:masterfrom
Conversation
This commit replaces deprecated failIf calls with assertFalse in the test_resourced_test_case.py file. The failIf method was removed in Python 3.12 [1-3]. [1] https://docs.python.org/3.12/whatsnew/3.12.html#removed [2] python/cpython#89325 [3] python/cpython#28268 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
May 31, 2023
It was necessary to patch two tests due to removed failIf method in py3.12. Upstream-PR: testing-cabal/testresources#15 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
May 31, 2023
It was necessary to patch two tests due to removed failIf method in py3.12. Upstream-PR: testing-cabal/testresources#15 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 31, 2023
It was necessary to patch two tests due to removed failIf method in py3.12. Upstream-PR: testing-cabal/testresources#15 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Signed-off-by: Michał Górny <mgorny@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces deprecated
failIfcalls withassertFalsein thetest_resourced_test_case.pyfile. ThefailIfmethod was removed in Python 3.12 [1-3].[1] https://docs.python.org/3.12/whatsnew/3.12.html#removed
[2] python/cpython#89325
[3] python/cpython#28268