Add scripts/ & benchmarks/ to directories checked by scripts/pylint#1047
Merged
Conversation
This adds ./scripts and ./benchmarks to directories where the linter is run.
This puts the code into a function instead of running the loop at the top level of the file. This makes pylint happier.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several utility scripts to improve code organization and linting coverage. Changes include adding docstrings to build_docs.py, wrapping the notebook formatting logic into a function in format_ipynb.py, and extending the linting script to include the benchmarks and scripts directories. A review comment suggests moving the notebook discovery logic inside the function to prevent side effects during import.
Per Gemini Code Assist, putting the assignment inside the function is better.
mhucka
changed the title
scripts/ & benchmarks/ to directories checked by scripts/pylint
mhucka
added
the
area/devops
MichaelBroughton
approved these changes
Apr 17, 2026
mhucka
added a commit
to mhucka/quantum
that referenced
this pull request
May 12, 2026
…low#1038) Scripts and workflows that run `yapf` currently each add the option `--style=google` to the invocation of `yapf`. To follow best practices, this PR adds a `.style.yapf` configuration file at the top level of the project to set the style, and removes the flag from where it was added on the command line explicitly. The use of a config file has the following benefits: - It lets tools like IDEs discover the setting automatically. - It reduces the chances that developers will forget to add the flag when they run `yapf` directly on the command line for quick checks, or write new scripts that use `yapf`. - It communicates intentions more clearly to new contributors. Removing the flag from the scripts is not strictly necessary (everything will work the same if there is both a config file and the flag is passed to `yapf`). However, if a config file is used, it's better for maintainability and consistency to also remove the flag from individual invocations. Note: the CI will fail the lint check until PR tensorflow#1047 is merged. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
./scriptsand./benchmarksto directories where the linter is run byscripts/lint_all.sh.Additional changes in a couple of other files are part of this PR because running the linter on those files resulted in linting errors that the changes fix.