You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Only having shape and dataType on Output is unintuitive and hard to find #146
I just spent an hour or so trying to figure out how to get the build-time shape of a graph operation. Had an issue ready to go and everything. It wasn't until I went poking around in the debugger that I realized it was on Output. I realize that there are design reasons to separate the output from the op, but asOutput() already exists, so I think having shape() and dataType() default methods on Operation that use asOutput is worth it from a usage and discovery standpoint.
Activity
karllessard commentedon Nov 14, 2020
I agree, these should be added to the
Operandinterface in fact, with a default implementation that fallbacks toasOutput().shape(), for example.Would you be interested doing it?
rnett commentedon Nov 14, 2020
Yeah, I can handle it.
rnett commentedon Dec 9, 2020
Fixed by #153