Use cibuildwheel and update grpcio#57
Conversation
|
|
cretz
force-pushed
the
cibuildwheel
branch
12 times, most recently
from
7f9ba27 to
ebe6762
Compare
cretz
force-pushed
the
cibuildwheel
branch
3 times, most recently
from
e4c7602 to
0334677
Compare
| # Rename the wheel file and confirm it is changed. We need to make it | ||
| # py37 minimum interpreter and abi3 compat. | ||
| wheel_file_pieces = existing_wheel_file.split("-") | ||
| if len(wheel_file_pieces) < 4: |
There was a problem hiding this comment.
nit:
Can this be > 4?
If it can't you can destructure into part1, part2, _py, _abi and replace the join with f"{part1}-{part2}-cp37-abi3" (replace part1 and part2 with meaningful names)
There was a problem hiding this comment.
While I haven't seen more than 4 (file + the 3 platform compat pieces), I am intentionally not assuming the number of parts here, just that I need to replace the third and fourth.
| # We separate out Linux aarch64 so we can choose not to run it during PR since | ||
| # it is so slow in cibuildwheel (uses QEMU emulation). We can put this back in | ||
| # the above matrix when Linux ARM runners are available. | ||
| compile-binaries-linux-aarch64: |
There was a problem hiding this comment.
nit: you can merge this with the matrix above and add conditions to skip in PR CI
There was a problem hiding this comment.
The job if can't include a matrix variable in its expression. It is evaluated before the matrix is loaded. There is also no "exit early" step for a job. Technically I could add an if to each step to skip linux aarch64 during PR, but that is ugly. There are also other ugly options: https://stackoverflow.com/questions/65384420/how-to-make-a-github-action-matrix-element-conditional.
This is the result of several attempts at several options (including workflow reuse which had little value and you can't use a strategy with a job use clause anyways).
(the original version did have these combined before it became clear Linux aarch64 was way too slow, but I still want to keep cibuildwheel's approach instead of custom cross-compile at least if/until we get Linux arm runners)
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Just a couple of nits, nothing blocking
3 participants
What was changed
Use
cibuildwheelin CI now and updategrpciopackage.Why?
cibuildwheelat least for its Linux docker capabilitiesgrpciomade a new release to fix its bad wheel naming for macOS arm buildsChecklist