Rework grpc locations and add some different structure#3
Merged
cretz merged 6 commits intotemporalio:mainfrom Jan 31, 2022
Merged
Rework grpc locations and add some different structure#3cretz merged 6 commits intotemporalio:mainfrom
cretz merged 6 commits intotemporalio:mainfrom
Conversation
bergundy
approved these changes
Jan 31, 2022
Member
|
Already reviewed in #2 |
mfateev
added a commit
to mfateev/sdk-python
that referenced
this pull request
Dec 27, 2025
- Convert Pydantic models to dataclasses in _models.py (item temporalio#3) - Standardize type annotations: replace Optional[X] with X | None (item temporalio#9) - Verify docstring style follows SDK conventions (item temporalio#4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio/proto/temporal/api->temporalio/apitemporalio/proto/dependencies->temporalio/api/dependenciestemporalio/proto/temporal/sdk->temporalio/bridge/protoLICENSEisortto format/lint taskmypylint check and mypy-protobuf supportpytesttask(carryover from #2)