Skip to content

[SDK Sentinel] Fix Nexus TRY_CANCEL cancellation test race #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tconley1428 merged 1 commit into from
Aug 25, 2026
Merged

[SDK Sentinel] Fix Nexus TRY_CANCEL cancellation test race #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/nexus/test_workflow_caller_cancellation_types_when_cancel_handler_fails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ async def run(self) -> None:
# For WAIT_REQUESTED, we want to prove that the future can be unblocked before the
# handler workflow completes.
await self.caller_op_future_resolved.wait()
elif (
test_context.cancellation_type
== workflow.NexusOperationCancellationType.WAIT_COMPLETED
elif test_context.cancellation_type in (
workflow.NexusOperationCancellationType.TRY_CANCEL,
workflow.NexusOperationCancellationType.WAIT_COMPLETED,
):
await self.release_completion.wait()

Expand Down Expand Up @@ -319,13 +319,15 @@ async def check_behavior_for_try_cancel(
caller_wf: WorkflowHandle[Any, CancellationResult],
handler_wf: WorkflowHandle[Any, None],
) -> None:
await handler_wf.result()
await test_context.cancel_handler_released

cancel_request_failed = EventType.EVENT_TYPE_NEXUS_OPERATION_CANCEL_REQUEST_FAILED
async for event in caller_wf.fetch_history_events(wait_new_event=True):
if event.event_type == cancel_request_failed:
break

await handler_wf.signal(HandlerWorkflow.set_release_completion)
await handler_wf.result()
await caller_wf.signal(CallerWorkflow.release)
result = await caller_wf.result()
assert result.error_type == "NexusOperationError"
Expand Down
Loading