Adding QueryWorkflowResponse Link for Nexus - #1723
Merged
JoshuaFrenchwood merged 4 commits intoAug 24, 2026
Merged
Conversation
mavemuri
approved these changes
Aug 6, 2026
JoshuaFrenchwood
force-pushed
the
frenchwood/add-link-to-query-workflow-response
branch
from
August 21, 2026 15:21
f6c76a4 to
0d479a2
Compare
JoshuaFrenchwood
marked this pull request as ready for review
August 21, 2026 15:49
JoshuaFrenchwood
force-pushed
the
frenchwood/add-link-to-query-workflow-response
branch
3 times, most recently
from
August 24, 2026 17:45
1b6ca71 to
2e30302
Compare
VegetarianOrc
requested changes
Aug 24, 2026
Comment on lines
+439
to
+441
| nexus_ctx = temporalio.nexus._operation_context._try_start_operation_context() | ||
| if nexus_ctx is not None and resp.HasField("link"): | ||
| nexus_ctx._add_response_link(resp.link) |
Contributor
There was a problem hiding this comment.
This is right, but let's move this logic to follow the pattern recently introduced by putting this into _operation_context.py
See #1771 for an example
Contributor
Author
There was a problem hiding this comment.
Updated, thanks
VegetarianOrc
approved these changes
Aug 24, 2026
JoshuaFrenchwood
force-pushed
the
frenchwood/add-link-to-query-workflow-response
branch
from
August 24, 2026 19:35
f9309ec to
c93e5f6
Compare
JoshuaFrenchwood
deleted the
frenchwood/add-link-to-query-workflow-response
branch
August 24, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adding QueryWorkflowResponse.Link for Nexus.
Why?
Checklist
Closes
How was this tested: