Skip to content

Fix System Nexus tracing headers - #1682

Open
tconley1428 wants to merge 12 commits into
mainfrom
fix/system-nexus-trace-headers
Open

Fix System Nexus tracing headers#1682
tconley1428 wants to merge 12 commits into
mainfrom
fix/system-nexus-trace-headers

Conversation

@tconley1428

@tconley1428 tconley1428 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a dedicated workflow outbound interceptor path for System Nexus operations
  • propagate tracing context through Temporal request headers instead of Nexus transport headers
  • add migration guidance for custom workflow interceptors

Validation

  • poe test -s tests/contrib/opentelemetry/test_opentelemetry_plugin.py -k signal_with_start
  • poe test -s tests/nexus/test_temporal_system_nexus.py -k 'external_workflow_handle_signal_with_start or headers_are_ignored'
  • poe lint

@tconley1428
tconley1428 requested a review from a team as a code owner July 27, 2026 18:31
@tconley1428
tconley1428 marked this pull request as draft July 27, 2026 18:42
@tconley1428
tconley1428 force-pushed the fix/system-nexus-trace-headers branch 9 times, most recently from 21628b5 to be4814a Compare August 21, 2026 21:37
@tconley1428
tconley1428 marked this pull request as ready for review August 24, 2026 16:13
VegetarianOrc
VegetarianOrc reviewed Aug 24, 2026
View reviewed changes
Comment thread temporalio/contrib/opentelemetry/_interceptor.py
@tconley1428
tconley1428 marked this pull request as draft August 24, 2026 18:08
@tconley1428

tconley1428 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Actually need to wait for an API update: temporalio/api#858

@tconley1428 tconley1428 mentioned this pull request Aug 24, 2026
Merged
tconley1428 added a commit to temporalio/api that referenced this pull request Aug 24, 2026
@tconley1428
Expose signal-with-start request headers (#858)
e80f8e2 
Expose the SignalWithStart request header field in the System Nexus WIT
source.
Intended to enable tracing propagation. See
temporalio/sdk-python#1682
temporal-cicd Bot pushed a commit to temporalio/api-go that referenced this pull request Aug 24, 2026
@tconley1428
Expose signal-with-start request headers (#858)
b19bac2 
Expose the SignalWithStart request header field in the System Nexus WIT
source.
Intended to enable tracing propagation. See
temporalio/sdk-python#1682
@tconley1428
tconley1428 changed the base branch from main to chore/update-sdk-core-origin-main August 25, 2026 16:14
@tconley1428
tconley1428 force-pushed the fix/system-nexus-trace-headers branch 3 times, most recently from 64a40fe to 7391021 Compare August 25, 2026 16:40
@tconley1428
tconley1428 marked this pull request as ready for review August 25, 2026 17:09
Base automatically changed from chore/update-sdk-core-origin-main to main August 25, 2026 17:11
@tconley1428
tconley1428 force-pushed the fix/system-nexus-trace-headers branch from 7391021 to 412c989 Compare August 25, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VegetarianOrc VegetarianOrc VegetarianOrc left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tconley1428 @VegetarianOrc