Skip to content

Default DNS lb config to None #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
THardy98 merged 3 commits into from
May 14, 2026
Merged

Default DNS lb config to None #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b4f46
default dns lb config to None
THardy98 May 13, 2026
9fc3528
default to None in the bridge as well
THardy98 May 13, 2026
e04df65
formatting
THardy98 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions temporalio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ async def connect(
lazy: bool = False,
runtime: temporalio.runtime.Runtime | None = None,
http_connect_proxy_config: HttpConnectProxyConfig | None = None,
dns_load_balancing_config: DnsLoadBalancingConfig
| None = DnsLoadBalancingConfig.default,
dns_load_balancing_config: DnsLoadBalancingConfig | None = None,
header_codec_behavior: HeaderCodecBehavior = HeaderCodecBehavior.NO_CODEC,
) -> Self:
"""Connect to a Temporal server.
Expand Down
4 changes: 1 addition & 3 deletions temporalio/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,7 @@ class ConnectConfig:
lazy: bool = False
runtime: temporalio.runtime.Runtime | None = None
http_connect_proxy_config: HttpConnectProxyConfig | None = None
dns_load_balancing_config: DnsLoadBalancingConfig | None = (
DnsLoadBalancingConfig.default
)
dns_load_balancing_config: DnsLoadBalancingConfig | None = None

def __post_init__(self) -> None:
"""Set extra defaults on unset properties."""
Expand Down
Loading