Skip to content

Pick up shutdown fix cherry-pick for v1.24.0#1516

Merged
yuandrew merged 4 commits into
temporalio:backport/poller-shutdown/1.24.0from
yuandrew:backport-poller-shutdown-1.24.0
May 13, 2026
Merged

Pick up shutdown fix cherry-pick for v1.24.0#1516
yuandrew merged 4 commits into
temporalio:backport/poller-shutdown/1.24.0from
yuandrew:backport-poller-shutdown-1.24.0

Conversation

@yuandrew
Copy link
Copy Markdown
Contributor

@yuandrew yuandrew commented May 13, 2026

What was changed

Point core to https://github.com/temporalio/sdk-rust/tree/backport/poller-shutdown/5f79ef2, which has a worker shutdown fix backported via temporalio/sdk-rust#1260

Pointed the features repo in CI to pre-S3 driver sample code, since that isn't in this older version, and also set a roof for types-protobuf to match what was available during the release, since newer version is causing CI to now fail

Why?

fix shutdown

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Medium Risk
Touches Rust worker shutdown plumbing in the Python bridge, which can affect runtime/thread behavior and shutdown correctness. The remaining changes are CI/dependency pinning to stabilize tests.

Overview
Fixes worker shutdown behavior in the Rust Python bridge by ensuring WorkerRef::initiate_shutdown enters the tokio runtime context (matching other sync bridge calls).

Stabilizes CI for this release line by pinning the temporalio/features workflow (and passing features-repo-ref) to a specific commit, and by adding an upper bound to types-protobuf in pyproject.toml/uv.lock to avoid newer stubs breaking older builds.

Reviewed by Cursor Bugbot for commit d9f2440. Bugbot is set up for automated code reviews on this repo. Configure here.

@yuandrew yuandrew requested a review from a team as a code owner May 13, 2026 16:57
@yuandrew yuandrew changed the title Pick up shutdown fix cherry-pick for v1.24.0 Pick up shutdown fix cherry-pick in prep for v1.24.1 May 13, 2026
@yuandrew yuandrew changed the title Pick up shutdown fix cherry-pick in prep for v1.24.1 Pick up shutdown fix cherry-pick for v1.24.0 May 13, 2026
@yuandrew yuandrew merged commit a528925 into temporalio:backport/poller-shutdown/1.24.0 May 13, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants