Pick up shutdown fix cherry-pick for v1.24.0#1516
Merged
yuandrew merged 4 commits intoMay 13, 2026
Merged
Conversation
jmaeagle99
approved these changes
May 13, 2026
THardy98
approved these changes
May 13, 2026
a528925
into
temporalio:backport/poller-shutdown/1.24.0
24 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Point core to https://github.com/temporalio/sdk-rust/tree/backport/poller-shutdown/5f79ef2, which has a worker shutdown fix backported via temporalio/sdk-rust#1260
Pointed the
featuresrepo in CI to pre-S3 driver sample code, since that isn't in this older version, and also set a roof for types-protobuf to match what was available during the release, since newer version is causing CI to now failWhy?
fix shutdown
Checklist
Closes
How was this tested:
Note
Medium Risk
Touches Rust worker shutdown plumbing in the Python bridge, which can affect runtime/thread behavior and shutdown correctness. The remaining changes are CI/dependency pinning to stabilize tests.
Overview
Fixes worker shutdown behavior in the Rust Python bridge by ensuring
WorkerRef::initiate_shutdownenters the tokio runtime context (matching other sync bridge calls).Stabilizes CI for this release line by pinning the
temporalio/featuresworkflow (and passingfeatures-repo-ref) to a specific commit, and by adding an upper bound totypes-protobufinpyproject.toml/uv.lockto avoid newer stubs breaking older builds.Reviewed by Cursor Bugbot for commit d9f2440. Bugbot is set up for automated code reviews on this repo. Configure here.