Fix external storage CaN test stability#1454
Merged
jmaeagle99 merged 6 commits intotemporalio:mainfrom Apr 23, 2026
Merged
Conversation
tconley1428
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add signal/handler to
test_extstore_continue_as_new_result_stored_under_current_runtest to fix race condition.Why?
The workflow used by
test_extstore_continue_as_new_result_stored_under_current_runquickly performs a CaN operation, which doesn't allow the test to deterministically get the original run ID before the final run ID. Add a signal handler to pace the workflow with the test expectations.Checklist