Experimental: External Payload Storage#1341
Merged
Merged
Conversation
f220f74 to
eeba791
Compare
tconley1428
reviewed
Feb 26, 2026
tconley1428
reviewed
Feb 26, 2026
cretz
reviewed
Feb 27, 2026
tconley1428
reviewed
Mar 10, 2026
Contributor
drewhoskins-temporal
left a comment
There was a problem hiding this comment.
Very excited! One important comment (which we already covered in our afternoon sync) and a bunch of polish suggestions.
tconley1428
approved these changes
Mar 16, 2026
|
|
||
| assert isinstance(err.value.cause, ActivityError) | ||
| assert isinstance(err.value.cause.cause, ApplicationError) | ||
| assert err.value.cause.cause.message == "Failed decoding arguments" |
Contributor
There was a problem hiding this comment.
Is there enough information here for users to understand and debug what happened? I'm not seeing it here.
| assert isinstance(err.value.cause.cause, ApplicationError) | ||
| assert ( | ||
| err.value.cause.cause.message | ||
| == "Driver 'bad-driver' returned 0 claims, expected 1" |
Contributor
There was a problem hiding this comment.
Suggested change
| == "Driver 'bad-driver' returned 0 claims, expected 1" | |
| == "ExternalStorageDriver 'bad-driver' returned 0 claims, expected 1." |
Here and on other diagnostics, please make sure to set context and to make it actionable.
- Context. What can't we do because this happened? "Cannot store a reference to uploaded payload." or something.
- Actionability. What should the user do to debug/fix? I'm guessing in this case it'd be "This is probably a bug in the ExternalStorageDriver."
| task_queue=worker.task_queue, | ||
| ) | ||
|
|
||
| await assert_task_fail_eventually(handle) |
Contributor
There was a problem hiding this comment.
Can we assert the message here? And as above, make sure we make an actionable suggestion for the user.
| return [] | ||
| if self._raise_payload_not_found: | ||
| raise ApplicationError( | ||
| "Payload not found because the bucket does not exist.", |
Contributor
There was a problem hiding this comment.
nit: I know this is just test code, but should echo the bad data (bucket ID) in the error message or its metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add external storage APIs to allow customers to specify how large payloads or payloads that match some specific customer-defined quality can be stored via customer-supplied external storage systems.
StorageDrivertype. This change does not contain any prebuilt drivers, just provides the primitives to make them.StorageDriverSelectorto participate in serialization context transforms.DataConverter.external_storage. There are no breaking changes regardless of opted into or not.Why?
Checklist