Improve X share card preview#46
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf7a25db33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47f9ccead3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
What changed
1200x630social share image atpublic/social-card.pngpublic/index.htmlso crawlers can render the homepage preview from raw HTMLcanonicaltag so catch-all HTML does not pin every route to the homepage URLog:urlfallback inpublic/index.htmlfor non-JavaScript crawlerssrc/components/PageMeta.jsto deriveog:urlfrom the router location and refresh it on path, query, and hash changessrc/components/PageMeta.test.jsfor same-component query-string navigation, starting from the staticog:urlshell stateWhy
Shared links on X needed a branded large-image preview, and review feedback surfaced separate SPA metadata issues around static canonical handling and raw-HTML Open Graph URL fallback.
Impact
sysnode.infoshould render with a branded large-image preview on X and other Open Graph consumers after deployment and cache refreshog:urlidentifier for crawlers that do not execute ReactValidation
npm run buildCI=true npm test -- --watchAll=false --runInBand src/components/PageMeta.test.js src/lib/formatters.test.js