[typescript-angular] error TS1345: An expression of type 'void' cannot be tested for truthiness #8836

[emmanuelgautier]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix formParams append issue depending on FormParams type. Related to issue #8836

[emmanuelgautier]

Any reviewer for this PR @mhardorf, @roni-frantchi ?

[roni-frantchi]

@emmanuelgautier Looks good to me. Personally I prefer the approach I suggested in #9012 as it eliminates that instanceof, but only by a slight. Would do you think?

[emmanuelgautier]

@roni-frantchi I did not see your PR and the related issue before. I give you a quick review on your code. This PR solution is not the most elegant way with this instanceof, but in both code conditions, issue with the HttpParams type still exists.

[emmanuelgautier]

Look this PR instead.