[JaxRS] Code generator does not honor implFolder on windows platform

[selliera]

Description

When using jaxrs-cxf-cdi and other JaxRS generators, the implFolder config is not honored by hte generator on windows.

The issue is due to file path manipulations in AbstractJavaJAXRSServerCodegen:apiFilename that uses '/' as a separator, while DefaultCodeGen:apiFilename uses File.separator since e7f4fb3 introduced for #7808

Swagger-codegen version

Tested on 2.3.1 and 2.4.0-SNAPSHOT, and this is a regression w.r.t. 2.2.2

Related issues/PRs

The issue that seemingly introduced the regression: #6443

Suggest a fix/enhancement

Use File.separator in AbstractJavaJAXRSServerCodegen:apiFilename

 @Override
  public String apiFilename(String templateName, String tag) {
      String result = super.apiFilename(templateName, tag);

      if ( templateName.endsWith("Impl.mustache") ) {
          int ix = result.lastIndexOf(File.separator);
          result = result.substring(0, ix) + "/impl" + result.substring(ix, result.length() - 5) + "ServiceImpl.java";
          result = result.replace(apiFileFolder(), implFileFolder(implFolder));
      } else if ( templateName.endsWith("Factory.mustache") ) {
          int ix = result.lastIndexOf(File.separator);
          result = result.substring(0, ix) + "/factories" + result.substring(ix, result.length() - 5) + "ServiceFactory.java";
          result = result.replace(apiFileFolder(), implFileFolder(implFolder));
      } else if ( templateName.endsWith("Service.mustache") ) {
          int ix = result.lastIndexOf('.');
          result = result.substring(0, ix) + "Service.java";
      }
      return result;
  }

[selliera]

Added the fix in pull request #8109, that is also about jax-rs generator.

[kalexmills]

This does not just affect the JaxRS generator. I am also having issues during the initial generation of a typescript-angular client on Windows due to the use of non-cross-platform path seperators. I'm seeing this issue also on the 3.0.0-rc1 branch.

See below for the command and error I am getting on Windows.

$ java -jar modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate -i openapi.json -l typescript-angular -o flavorate-api -v -t typescript-angular
[Thread-0] INFO io.swagger.codegen.config.CodegenConfigurator -
VERBOSE MODE: ON. Additional debug options are injected
 - [debugSwagger] prints the swagger specification as interpreted by the codegen
 - [debugModels] prints models passed to the template engine
 - [debugOperations] prints operations passed to the template engine
 - [debugSupportingFiles] prints additional data passed to the template engine
[Thread-0] INFO io.swagger.codegen.ignore.CodegenIgnoreProcessor - No .swagger-codegen-ignore file found.
{
  "openapi" : "3.0.1",
  "info" : {
    "title" : "Flavorate User Service",
    "description" : "Flavorate User API",
    "version" : "0.0"
  },
  "servers" : [ {
    "url" : "/"
  } ],
  "paths" : {
    "/user/login/refresh" : {
      "get" : {
        "tags" : [ "user" ],
        "summary" : "Refresh a valid user's token.",
        "operationId" : "doRefresh",
        "responses" : {
          "default" : {
            "description" : "Fresh token for you.",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/LoginResponse"
                }
              }
            }
          },
          "401" : {
            "description" : "Token was not valid."
          }
        },
        "security" : [ {
          "bearerToken" : [ ]
        } ]
      }
    },
    "/user/login" : {
      "get" : {
        "tags" : [ "user" ],
        "summary" : "Login a user.",
        "operationId" : "doLogin",
        "responses" : {
          "default" : {
            "description" : "A login token.",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/LoginResponse"
                }
              }
            }
          },
          "401" : {
            "description" : "User credentials were invalid."
          }
        },
        "security" : [ {
          "basicAuth" : [ ]
        } ]
      }
    },
    "/user/register" : {
      "post" : {
        "tags" : [ "user" ],
        "description" : "Register a new user",
        "operationId" : "registerUser",
        "requestBody" : {
          "description" : "Registration request.",
          "content" : {
            "application/json" : {
              "schema" : {
                "$ref" : "#/components/schemas/RegisterRequest"
              }
            }
          },
          "required" : true
        },
        "responses" : {
          "default" : {
            "description" : "Registration successful",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/RegisterResponse"
                }
              }
            }
          },
          "409" : {
            "description" : "Requested phone or email already taken."
          }
        }
      }
    },
    "/user/validate" : {
      "post" : {
        "tags" : [ "user" ],
        "description" : "Validate a new user's phone or e-mail account.",
        "operationId" : "validateUser",
        "requestBody" : {
          "description" : "Validation code.",
          "content" : {
            "application/json" : {
              "schema" : {
                "$ref" : "#/components/schemas/ValidationRequest"
              }
            }
          },
          "required" : true
        },
        "responses" : {
          "default" : {
            "description" : "default response",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/RegisterResponse"
                }
              }
            }
          }
        }
      }
    }
  },
  "components" : {
    "schemas" : {
      "RegisterRequest" : {
        "required" : [ "name", "password" ],
        "type" : "object",
        "properties" : {
          "phone" : {
            "type" : "string"
          },
          "email" : {
            "type" : "string"
          },
          "validationStatus" : {
            "type" : "string",
            "enum" : [ "NONE_VALIDATED", "PHONE_VALIDATED", "EMAIL_VALIDATED", "PHONE_AND_EMAIL_VALIDATED" ]
          },
          "name" : {
            "type" : "string"
          },
          "password" : {
            "type" : "string"
          },
          "containsPhoneOrEmail" : {
            "type" : "boolean"
          }
        }
      },
      "RegisterResponse" : {
        "type" : "object",
        "properties" : {
          "success" : {
            "type" : "boolean"
          }
        }
      },
      "LoginResponse" : {
        "type" : "object",
        "properties" : {
          "token" : {
            "type" : "string"
          }
        }
      },
      "ValidationRequest" : {
        "required" : [ "credentialType" ],
        "type" : "object",
        "properties" : {
          "code" : {
            "type" : "string"
          },
          "credentialType" : {
            "type" : "string",
            "enum" : [ "PHONE", "EMAIL" ]
          }
        }
      }
    },
    "securitySchemes" : {
      "bearerToken" : {
        "type" : "http",
        "in" : "header",
        "scheme" : "Bearer",
        "bearerFormat" : "JWT"
      },
      "basicAuth" : {
        "type" : "http",
        "in" : "header",
        "scheme" : "Basic"
      }
    }
  }
}
[Thread-0] INFO io.swagger.codegen.DefaultCodegen - generating code for Angular 4.3.0 ...
[Thread-0] INFO io.swagger.codegen.DefaultCodegen -   (you can select the angular version by setting the additionalProperty ngVersion)
Exception in thread "Thread-0" java.lang.RuntimeException: Could not generate model 'LoginResponse'
        at io.swagger.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:407)
        at io.swagger.codegen.DefaultGenerator.generate(DefaultGenerator.java:722)
        at io.swagger.codegen.cmd.Generate.run(Generate.java:312)
        at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.util.regex.PatternSyntaxException: Illegal/unsupported escape sequence near index 3
C:\Users\kalex\Sanity\flavorate\swagger-codegen\typescript-angular
   ^
        at java.base/java.util.regex.Pattern.error(Unknown Source)
        at java.base/java.util.regex.Pattern.escape(Unknown Source)
        at java.base/java.util.regex.Pattern.atom(Unknown Source)
        at java.base/java.util.regex.Pattern.sequence(Unknown Source)
        at java.base/java.util.regex.Pattern.expr(Unknown Source)
        at java.base/java.util.regex.Pattern.compile(Unknown Source)
        at java.base/java.util.regex.Pattern.<init>(Unknown Source)
        at java.base/java.util.regex.Pattern.compile(Unknown Source)
        at java.base/java.lang.String.replaceFirst(Unknown Source)
        at io.swagger.codegen.DefaultGenerator.getHandlebars(DefaultGenerator.java:1007)
        at io.swagger.codegen.DefaultGenerator.processTemplateToFile(DefaultGenerator.java:738)
        at io.swagger.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:394)
        ... 3 more

The software appears to be treating the windows path as an escaped String because the wrong file separator is being used.