feat(nix): build pgbackrest from source instead of nixpkgs passthrough#2267
Open
hunleyd wants to merge 1 commit into
Open
feat(nix): build pgbackrest from source instead of nixpkgs passthrough#2267hunleyd wants to merge 1 commit into
hunleyd wants to merge 1 commit into
Conversation
nix/packages/default.nix's pg-backrest output was a raw passthrough to nixpkgs.legacyPackages.pgbackrest, so the AMI and multigres Docker images got whatever version nixpkgs-unstable happened to have pinned, with no control over optional build features. Add nix/packages/pgbackrest.nix, a from-scratch meson/ninja build pinned to pgBackRest 2.58.0 (latest stable), mirroring the wal-g.nix pattern of an explicit, version-pinned source build. libzstd is forced enabled (not left on meson's "auto" detection) and libssh2/SFTP is disabled since only S3 is needed for now; S3/GCS/Azure support itself isn't meson-gated so nothing else changes there. Registers the new derivation in nix/packages/default.nix and adds it to the enumerated build-check list in nix/checks.nix (mirroring wal-g-2) so CI verifies it builds. No changes needed in ansible/tasks/setup-pgbackrest.yml or Dockerfile-multigres: both consume the pg-backrest flake output by name and continue to get a pgbackrest binary in $out/bin.
PostgreSQL Extension Dependency Analysis: PR #2267
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2267
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix/packages/default.nix'spg-backrestoutput was a raw passthrough tonixpkgs.legacyPackages.pgbackrest(a stopgap), giving no control over version or optional build featuresnix/packages/pgbackrest.nix: a from-scratch meson/ninja build pinned to pgBackRest 2.58.0 (latest stable as of writing), mirroring thewal-g.nixpattern of explicit version-pinned source buildslibzstdis forcedenabled(not left on meson'sautodetection);libssh2/SFTP isdisabledsince only S3 is needed right now — S3/GCS/Azure storage support itself isn't meson-gated, so nothing else changes therenix/packages/default.nixand adds it to the enumerated build-check list innix/checks.nix(mirroringwal-g-2) so CI verifies it buildsNo changes needed in
ansible/tasks/setup-pgbackrest.ymlorDockerfile-multigres— both consume thepg-backrestflake output by name and continue to get apgbackrestbinary in$out/bin.Resolves INDATA-520.
Test plan
nix build .#pg-backrestsucceeds./result/bin/pgbackrest versionreports2.58.0zstdand does not includelibssh2nix build .#checks.<system>.pg-backrestsucceeds