Fixed #1061 Failed Snippets Tests#1162
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1162 |
|
Now that we've confirmed that the unit tests are failing as expected, we can now add the code to fix this |
|
@NimaSarajpoor Please review at your earliest convenience. After this, I will make modifications to the |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
Awesome. I've added a couple of comments for your consideration.
|
Sharing here before I forget: once this is merged, #1080 can be closed. |
I added the failing unit tests (found in those comments) to this PR |
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory