Repository navigation
feat: add lapack/base/dlartgp - #9608
prajjwalbajpai wants to merge 5 commits into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@kgryte the test coverage is not 100% due to this part in if ( r < 0.0 ) {
cs *= -1;
sn *= -1;
r *= -1;
}This was a precautionary check used in the Fortran code but I believe it is not necessary with JavaScript. |
Updated the comment to clarify the purpose of the LAPACK routine. Signed-off-by: Prajjwal Bajpai <142303989+prajjwalbajpai@users.noreply.github.com>
Signed-off-by: Prajjwal Bajpai <142303989+prajjwalbajpai@users.noreply.github.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
| // MAIN // | ||
|
|
||
| /** | ||
| * Generates a plane rotation so that the diagonal is nonnegative. |
There was a problem hiding this comment.
| * Generates a plane rotation so that the diagonal is nonnegative. | |
| * Generates a plane rotation so that the diagonal is nonnegative. | |
| * |
| /** | ||
| * Generates a plane rotation so that the diagonal is nonnegative. | ||
| * @private | ||
| * @param {number} F - the first component of vector to be rotated. |
There was a problem hiding this comment.
| * @param {number} F - the first component of vector to be rotated. | |
| * @param {number} F - the first component of vector to be rotated |
No periods at the end of JSDoc descriptions. Applies here and throughout this PR.
| * dlartgp( 1.0, 2.0, out, 1, 0 ); | ||
| * // out => <Float64Array>[ ~0.447, ~0.894, ~2.236 ] | ||
| */ | ||
| var dlartgp = base; |
There was a problem hiding this comment.
| var dlartgp = base; | |
| function dlartgp( F, G, out, strideOut, offsetOut ) { | |
| return base( F, G, out, strideOut, offsetOut ); | |
| } |
One line wrapper to match conventions elsewhere.
| * @name dlartgp | ||
| * @type {Function} |
There was a problem hiding this comment.
| * @name dlartgp | |
| * @type {Function} |
| * | ||
| * @name dlartgp | ||
| * @type {Function} | ||
| * @param {number} F - the first component of vector to be rotated. |
There was a problem hiding this comment.
| * @param {number} F - the first component of vector to be rotated. | |
| * @param {number} F - the first component of vector to be rotated |
Description punctuation.
| Parameters | ||
| ---------- | ||
| F: number | ||
| The first component of vector to be rotated. |
There was a problem hiding this comment.
| The first component of vector to be rotated. | |
| The first component of the vector to be rotated. |
| The first component of vector to be rotated. | ||
|
|
||
| G: number | ||
| The second component of vector to be rotated. |
There was a problem hiding this comment.
| The second component of vector to be rotated. | |
| The second component of the vector to be rotated. |
Applies here and throughout this PR.
|
|
||
| out: Float64Array | ||
| Output array containing the cosine and sine of the rotation and the | ||
| non zero component of the rotated vector, respectively. |
There was a problem hiding this comment.
| non zero component of the rotated vector, respectively. | |
| nonzero component of the rotated vector, respectively. |
Applies here and throughout this PR.
|
|
||
|
|
||
| {{alias}}.ndarray( F, G, out, strideOut, offsetOut ) | ||
| Generates a plane rotation so that the diagonal is nonnegative. |
There was a problem hiding this comment.
| Generates a plane rotation so that the diagonal is nonnegative. | |
| Generates a plane rotation so that the diagonal is nonnegative using alternative indexing semantics. |
You'll need to rewrap the line.
| Generates a plane rotation so that the diagonal is nonnegative. | ||
|
|
||
| While typed array views mandate a view offset based on the underlying | ||
| buffer, the offset parameters support indexing semantics based on starting |
There was a problem hiding this comment.
| buffer, the offset parameters support indexing semantics based on starting | |
| buffer, the offset parameter supports indexing semantics based on a starting |
|
|
||
| While typed array views mandate a view offset based on the underlying | ||
| buffer, the offset parameters support indexing semantics based on starting | ||
| indices. |
There was a problem hiding this comment.
| indices. | |
| index. |
|
|
||
| // MAIN // | ||
|
|
||
| bench( pkg+':ndarray', function benchmark( b ) { |
There was a problem hiding this comment.
@prajjwalbajpai Mind updating this to use format? Cheers!
Description
This pull request:
lapack/base/dlartgpRelated Issues
This pull request has the following related issues:
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
NA
@stdlib-js/reviewers