Repository navigation
feat: add lapack/base/dlae2 - #2824
Pranavchiku wants to merge 6 commits into
Conversation
| var expected; | ||
| var out; | ||
|
|
||
| out = new Float64Array( 2 ); |
There was a problem hiding this comment.
And just checking: do the various test cases below ensure 100% code coverage?
There was a problem hiding this comment.
Let me check, I have not checked yet.
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function supports complex access pattern to store computed values', function test( t ) { |
There was a problem hiding this comment.
For tests, always test to the interface, not the implementation. Here, you're doing the latter, taking shortcuts because you know that various accuracy tests are in test.dlae.js. Don't do that. When testing to the interface, you must assume that behind the interface is a separate, independent implementation. That means writing tests which share similarities with other tests for similar interfaces.
kgryte
left a comment
There was a problem hiding this comment.
Left a first round of comments.
|
Looks like the tests still need to be updated. |
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dlae2Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers