Repository navigation
Conversation
4 of 7 tasks
Author
|
@Pranavchiku Kindly review this PR. |
@stdlib/string/base/distances/hamming-code-points
kgryte
reviewed
Apr 8, 2024
| } | ||
| res = 0; | ||
| for ( i = 0; i < s1.length; i++ ) { | ||
| if (s1.codePointAt( i ) !== s2.codePointAt( i )) { |
Member
There was a problem hiding this comment.
This implementation is not correct. It will overcount.
Author
There was a problem hiding this comment.
In new commit I added: if code point value is higher than 0xffff then shift pointer by one to deal with overcount.
Member
|
CI is failing on this PR, and, until the failures are resolved, this PR cannot move forward. |
Author
|
Hello Sir @kgryte please review my PR. I changed some logic in the main function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calculates the Hamming Code Points Distance distance between two equal-length unicode code points.
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers