Repository navigation
build: replace eslint-plugin-node with eslint-plugin-n (gh54 part II) - #10952
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
eslint-plugin-node with eslint-plugin-neslint-plugin-node with eslint-plugin-n
ac2468f to
ff1e4ba
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
eslint-plugin-node with eslint-plugin-neslint-plugin-node with eslint-plugin-n (gh54 part II)
4fbfcbf to
7f06a75
Compare
|
@Planeshifter Heads-up: looks like stacking went sideways. Would you mind resolving the merge conflicts? |
|
Actually, I think I know what happened. It went sideways because I had deleted the base branch on the GitHub UI. And it is not clear to me how to move this PR back against the restored base branch. :( |
|
Maybe you can force push to move it back on the original base branch? 😬 |
7f06a75 to
dd197bb
Compare
Coverage ReportNo coverage information available. |
|
/stdlib merge |
@kgryte, the slash command failed to complete. Please check the workflow logs for details. |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>
|
|
||
| tape( 'the plugin successfully lints valid Markdown not containing any HTML sections', opts, function test( t ) { | ||
| var fpath = join( __dirname, 'fixtures', 'valid_no_sections.md.txt' ); | ||
| var file = readSync( fpath, 'utf8' ); |
There was a problem hiding this comment.
It's odd that in a previous test file you had to disable the lint rule, but here you are not.
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
|
As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge. |
Progresses stdlib-js/metr-issue-tracker#54.
Description
This pull request:
eslint-plugin-node(v11) with its actively maintained forkeslint-plugin-n(v17) (PR 3 of the migration plan).nodetoninetc/eslint/plugins/index.js.node/*ton/*inetc/eslint/rules/nodejs.js.eslint-disablecomments across the codebase fromnode/ton/.tryExtensionsoption fromn/file-extension-in-import(no longer supported byeslint-plugin-n).eslint-plugin-n:bigintandhashbanginn/no-unsupported-features/es-syntax,http2andprocess.releaseinn/no-unsupported-features/node-builtins.@nametags and documentation URLs to point to theeslint-community/eslint-plugin-nrepository.log/logErrorfunctions to outer scope inremark-run-javascript-examplesand fixes pre-existing lint violations in touched files.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Stacked on #10950.
eslint-plugin-nis the community-maintained fork of the unmaintainedeslint-plugin-nodeand is required for ESLint v9 compatibility./* eslint-disable node/shebang */were removed in various place because the new rule has different behavior:Since
eslint-plugin-n's rule selector isCallExpression > Identifier[name=/Sync$/] (and the MemberExpression variant), it only fires on call expressions whose final identifier ends in Sync. Hence property access duringrequirecalls is not flagged anymore and calling function is only flagged if the aliases actually end inSync. This is the reason for various removed lint overrides.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. The bulk rename was done via scripted sed, with manual review of config changes and rule compatibility.
@stdlib-js/reviewers