[6.x] Allow ensuring fields in fieldsets - #11097
Open
duncanmcclean wants to merge 8 commits into
Open
duncanmcclean wants to merge 8 commits into
duncanmcclean wants to merge 8 commits into
Conversation
5 tasks
duncanmcclean
added a commit
to statamic/importer
that referenced
this pull request
Nov 12, 2024
duncanmcclean
changed the title
…eldsets # Conflicts: # src/Fields/Fieldset.php
…et fields Stop array_filtering fieldset contents, which dropped the empty fields key on every fieldset, and restore the StoreFieldsetTest expectation. Ensured fields now go into the first section when a fieldset uses sections, keep their position when they already exist in a later section, and no longer discard existing reference or import config overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Import overrides are keyed by the unprefixed handle, so ensuring a field inside a prefixed import now writes to the key the import actually reads. ensureFieldHasConfig now matches Blueprint: it merges the requested config over existing inline, reference, and import config, and updates deferred ensured fields, instead of only filling missing keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the ability to ensure fields in fieldsets, copying most of the logic and tests from the blueprint implementation.
This would help to simplify some of the code in the importer around ensuring & saving fields in fieldsets.
This PR doesn't fix any of the open issues regarding ensuring imported fields in blueprints.