Skip to content

Fix performance regression in latest falco#709

Merged
Stringy merged 3 commits into
masterfrom
giles/fix-performance-regression
Jun 1, 2022
Merged

Fix performance regression in latest falco#709
Stringy merged 3 commits into
masterfrom
giles/fix-performance-regression

Conversation

@Stringy

@Stringy Stringy commented May 31, 2022

Copy link
Copy Markdown
Collaborator

Description

Bumps the falco commit to include a fix for a performance regression in which the global g_bpf_drop_syscalls was no longer in use.

Checklist

  • Investigated and inspected CI test results
    - [ ] Updated documentation accordingly

Automated testing
- [ ] Added unit tests
- [ ] Added integration tests
- [ ] Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Local testing and relying on CI for other platforms.

@openshift-ci

openshift-ci Bot commented May 31, 2022

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Stringy Stringy force-pushed the giles/fix-performance-regression branch from b737eca to ce9cd9b Compare May 31, 2022 13:06
@Stringy Stringy force-pushed the giles/fix-performance-regression branch from ce9cd9b to f4d6df7 Compare May 31, 2022 14:46
@ghost

ghost commented Jun 1, 2022

Copy link
Copy Markdown
COLLECTOR_TAG=3.8.x-85-g974e404b88
COLLECTOR_BUILDER_TAG=cache

Results for Performance Benchmarks on build #256182

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
rhel.rhel-7 ebpf 220.956 268.234 161.3 360.07 🔴
rhel.rhel-7 module 223.406 265.599 141.23 163.3 🔴
rhel.rhel-8 ebpf 219.009 272.65 171.25 371.77 🔴
rhel.rhel-8 module 214.456 241.318 171.05 192.4 🟢
ubuntu-os-pro.ubuntu-pro-1804-lts ebpf 125.049 161.195 148.26 355.46 🔴
ubuntu-os-pro.ubuntu-pro-1804-lts module 204.814 227.847 172.84 200.6 🟢
ubuntu-os.ubuntu-1804-lts ebpf 200.348 261.823 151.6 381.68 🔴
ubuntu-os.ubuntu-1804-lts module 192.883 216.919 153.36 175.02 🟢
ubuntu-os.ubuntu-2004-lts ebpf 208.619 239.844 168.54 350.18 🔴
ubuntu-os.ubuntu-2004-lts module 201.809 226.916 176.15 199.22 🟢
ubuntu-os.ubuntu-2204-lts ebpf 197.541 208.034 198.73 365.6 🔴
ubuntu-os.ubuntu-2204-lts module 198.18 186.022 213.5 230.88 🔴

@Stringy Stringy marked this pull request as ready for review June 1, 2022 07:12
@Stringy Stringy requested a review from a team as a code owner June 1, 2022 07:12
@Stringy

Stringy commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

The performance numbers above relate to fixing the mistaken regression in from #601 and specifically the performance seen in this comment: #601 (comment)

@Stringy Stringy merged commit d1efbca into master Jun 1, 2022
@Stringy Stringy deleted the giles/fix-performance-regression branch June 1, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants