Fix performance regression in latest falco#709
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
b737eca to
ce9cd9b
Compare
ce9cd9b to
f4d6df7
Compare
Results for Performance Benchmarks on build #256182
|
Collaborator
Author
|
The performance numbers above relate to fixing the mistaken regression in from #601 and specifically the performance seen in this comment: #601 (comment) |
erthalion
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the falco commit to include a fix for a performance regression in which the global
g_bpf_drop_syscallswas no longer in use.Checklist
- [ ] Updated documentation accordinglyAutomated testing
- [ ] Added unit tests- [ ] Added integration tests- [ ] Added regression testsIf any of these don't apply, please comment below.
Testing Performed
Local testing and relying on CI for other platforms.