This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Repository navigation
[2.7] Protect climb_stack_and_eval_frame from trivialization - #227
Merged
Merged
Conversation
gcc >= 4.7 trivializes not only climb_stack_and_transfer, but also climb_stack_and_eval_frame. Thus the same global-write trick must be used both there and here.
akruis
approved these changes
Aug 23, 2019
akruis
left a comment
akruis
left a comment
There was a problem hiding this comment.
Looks good. Thank you for reporting this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc-4.8.5 (and possibly other versions between 4.7 and 5.4) trivializes both instances of the side-effect-only
allocatrick: not only climb_stack_and_transfer, but also climb_stack_and_eval_frame.Thus the same global-write trick must be used both there and here.
(This is of course entirely inapplicable to 3.x and master, due to #163.)