feat(cdn): implement redirects by matheuspolitano · Pull Request #1333 · stackitcloud/terraform-provider-stackit

matheuspolitano · 2026-03-27T13:24:52Z

Description

In case there is no issue present for your PR, please consider creating one.
At least please give us some description what you are trying to achieve and why your change is needed. -->

relates to #1234

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

rubenhoenle · 2026-03-27T16:49:57Z

Could you please adjust the acc tests to include the new fields? 😅

matheuspolitano · 2026-03-31T17:10:16Z

Could you please adjust the acc tests to include the new fields? 😅

its done :)

matheuspolitano · 2026-04-13T07:10:48Z

@rubenhoenle @marceljk its done already the acc_test over weeks, Could you check again?

marceljk · 2026-04-20T14:21:57Z

+														Description: schemaDescriptions["config_redirects_rule_match_condition"],
+														Default:     stringdefault.StaticString("ANY"),
+														Computed:    true,
+														Validators:  []validator.String{stringvalidator.OneOfCaseInsensitive(matchCondition...)},


You can use here the generated enums from the SDK. So we don't need to manually maintain the valid values.

Suggested change

Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(matchCondition...)},

Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(sdkUtils.EnumSliceToStringSlice(cdnSdk.AllowedMatchConditionEnumValues)...)},

marceljk · 2026-04-20T14:23:24Z

+											Computed:    true,
+											Description: schemaDescriptions["config_redirects_rule_match_condition"],
+											Default:     stringdefault.StaticString("ANY"),
+											Validators:  []validator.String{stringvalidator.OneOfCaseInsensitive(matchCondition...)},


same here

Suggested change

Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(matchCondition...)},

Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(sdkUtils.EnumSliceToStringSlice(cdnSdk.AllowedMatchConditionEnumValues)...)},

marceljk · 2026-04-20T14:23:55Z


 func (r *distributionResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) {
 	backendOptions := []string{"http", "bucket"}
+	matchCondition := []string{"ANY", "ALL", "NONE"}


can be removed

Suggested change

matchCondition := []string{"ANY", "ALL", "NONE"}

marceljk · 2026-04-20T14:36:12Z

+					var tfValues []attr.Value
+					if m.Values != nil {
+						for _, v := range m.Values {
+							tfValues = append(tfValues, types.StringValue(v))
+						}
+					}
+					tfValuesList, diags := types.ListValue(types.StringType, tfValues)
+					if diags.HasError() {
+						return core.DiagsToError(diags)
+					}


can be simplified

Suggested change

var tfValues []attr.Value

if m.Values != nil {

for _, v := range m.Values {

tfValues = append(tfValues, types.StringValue(v))

}

}

tfValuesList, diags := types.ListValue(types.StringType, tfValues)

if diags.HasError() {

return core.DiagsToError(diags)

}

tfValuesList, diags := types.ListValueFrom(ctx, types.StringType, m.Values)

if diags.HasError() {

return core.DiagsToError(diags)

}

marceljk · 2026-04-20T14:43:14Z

+
+			tfStatusCode := types.Int32Null()
+			if r.StatusCode > 0 {
+				tfStatusCode = types.Int32Value(int32(r.StatusCode)) // nolint:gosec // HTTP status codes are safely within int32 bounds


redundant. probably solves also the linter issue

Suggested change

tfStatusCode = types.Int32Value(int32(r.StatusCode)) // nolint:gosec // HTTP status codes are safely within int32 bounds

tfStatusCode = types.Int32Value(r.StatusCode)

marceljk · 2026-04-20T15:08:41Z

+	redirectsObjType, ok := configTypes["redirects"].(basetypes.ObjectType)
+	if !ok {
+		t.Fatalf("configTypes[\"redirects\"] is not of type basetypes.ObjectType")
+	}
+	redirectsAttrTypes := redirectsObjType.AttrTypes
+
 	config := types.ObjectValueMust(configTypes, map[string]attr.Value{
 		"backend":           backend,
 		"regions":           regionsFixture,
 		"optimizer":         types.ObjectNull(optimizerTypes),
 		"blocked_countries": blockedCountriesFixture,
+		"redirects":         types.ObjectNull(redirectsAttrTypes),


simplify it like in the previous test function

marceljk · 2026-04-20T15:09:14Z

+				RuleMatchCondition: cdnSdk.MatchCondition("ANY").Ptr(),
+				Matchers: []cdnSdk.Matcher{
+					{
+						Values:              []string{"/shop/*"},
+						ValueMatchCondition: cdnSdk.MatchCondition("ANY").Ptr(),


use here the enums

marceljk · 2026-04-20T15:09:39Z

+	redirectsObjType, ok := configTypes["redirects"].(basetypes.ObjectType)
+	if !ok {
+		t.Fatalf("configTypes[\"redirects\"] is not of type basetypes.ObjectType")
+	}
+	redirectsAttrTypes := redirectsObjType.AttrTypes
+
 	config := types.ObjectValueMust(configTypes, map[string]attr.Value{
 		"backend":           backend,
 		"regions":           regionsFixture,
 		"blocked_countries": blockedCountriesFixture,
 		"optimizer":         types.ObjectNull(optimizerTypes),
+		"redirects":         types.ObjectNull(redirectsAttrTypes),
+	})


simplify it here

marceljk · 2026-04-20T15:10:08Z

+							RuleMatchCondition: cdnSdk.MatchCondition("ANY").Ptr(),
+							Matchers: []cdnSdk.Matcher{
+								{
+									Values:              []string{"/shop/*"},
+									ValueMatchCondition: cdnSdk.MatchCondition("ANY").Ptr(),


use the existing enums

marceljk · 2026-04-20T15:16:45Z

 					),

+					resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.#", "1"),
+					resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.0.target_url", "https://example.com/updated"),


Suggested change

resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.0.target_url", "https://example.com/updated"),

resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.0.target_url", testutil.ConvertConfigVariable(configVarsHttpUpdated()["https://example.com/updated"])),

Matheus Politano added 5 commits March 26, 2026 17:49

feat: add redirects in convertConfig

7c989aa

feat: add redirect in toCreatePayload

7cca33f

feat: add redirect in the update function

e850a14

feat: add in the map field mapfield

cf6f255

small fix and add datasource

72d079c

matheuspolitano requested a review from a team as a code owner March 27, 2026 13:24

matheuspolitano changed the title ~~feat(cdn): implement new bucket backend type~~ feat(cdn): implement redirects Mar 27, 2026

Matheus Politano added 2 commits March 27, 2026 14:26

chore: update doc

cafad57

chore: add resource example

f2bcc1b

rubenhoenle added the needs-work PR needs changes by the author. label Mar 27, 2026

matheuspolitano force-pushed the mp/cdn/feat/implement-redirects branch 2 times, most recently from ae228fb to f2bcc1b Compare March 31, 2026 12:25

Matheus Politano added 4 commits March 31, 2026 14:37

Merge branch 'main' into mp/cdn/feat/implement-redirects

a5f9f48

chore: add redirect in acc test and address linter issues

9addaea

chore: address linter issue

618c3a2

chore: add doc

9a22cef

matheuspolitano and others added 3 commits March 31, 2026 19:10

Merge branch 'main' into mp/cdn/feat/implement-redirects

83c4b94

Merge branch 'main' into mp/cdn/feat/implement-redirects

6d30d9b

chore: adjust for the new sdk version

cf12967

matheuspolitano force-pushed the mp/cdn/feat/implement-redirects branch from 84a7ff9 to cf12967 Compare April 1, 2026 18:49

Matheus Politano and others added 3 commits April 1, 2026 20:58

chore: implement new sdk in cdn_acc_test

45905c6

Merge branch 'main' into mp/cdn/feat/implement-redirects

92dfd6f

Merge branch 'main' into mp/cdn/feat/implement-redirects

9ccd292

Merge branch 'main' into mp/cdn/feat/implement-redirects

56f3e9c

matheuspolitano mentioned this pull request Apr 13, 2026

feat(cdn): Add support for configuring WAF #1372

Open

8 tasks

FYI: add all field in acc_test

7f5e08d

rubenhoenle removed the needs-work PR needs changes by the author. label Apr 20, 2026

rubenhoenle added the has internal tracking issue label Apr 20, 2026

marceljk reviewed Apr 20, 2026

View reviewed changes

	Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(matchCondition...)},
	Validators: []validator.String{stringvalidator.OneOfCaseInsensitive(sdkUtils.EnumSliceToStringSlice(cdnSdk.AllowedMatchConditionEnumValues)...)},

	tfStatusCode = types.Int32Value(int32(r.StatusCode)) // nolint:gosec // HTTP status codes are safely within int32 bounds
	tfStatusCode = types.Int32Value(r.StatusCode)

	resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.0.target_url", "https://example.com/updated"),
	resource.TestCheckResourceAttr("stackit_cdn_distribution.distribution", "config.redirects.rules.0.target_url", testutil.ConvertConfigVariable(configVarsHttpUpdated()["https://example.com/updated"])),

Conversation

matheuspolitano commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

rubenhoenle commented Mar 27, 2026

Uh oh!

matheuspolitano commented Mar 31, 2026

Uh oh!

matheuspolitano commented Apr 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matheuspolitano commented Mar 27, 2026 •

edited

Loading