Skip to content

Onboard IaaS security group rule commands#523

Merged
GokceGK merged 21 commits into
mainfrom
gg/onboard-iaas-security-group-rule-commands
Dec 12, 2024
Merged

Onboard IaaS security group rule commands#523
GokceGK merged 21 commits into
mainfrom
gg/onboard-iaas-security-group-rule-commands

Conversation

@GokceGK
Copy link
Copy Markdown
Contributor

@GokceGK GokceGK commented Dec 5, 2024

No description provided.

Copy link
Copy Markdown
Contributor

@Fyusel Fyusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet finished need to have another look on monday.

Comment thread internal/cmd/beta/security-group-rule/create/create.go
Comment thread internal/cmd/beta/security-group-rule/create/create.go Outdated
Comment thread internal/cmd/beta/security-group-rule/create/create.go Outdated
Comment thread internal/cmd/beta/security-group-rule/create/create_test.go
Comment thread internal/cmd/beta/security-group-rule/list/list.go Outdated
Comment thread internal/cmd/beta/security-group-rule/delete/delete_test.go
Comment thread internal/cmd/beta/security-group-rule/delete/delete_test.go
Comment thread internal/cmd/beta/security-group-rule/delete/delete_test.go
Comment thread internal/cmd/beta/security-group-rule/delete/delete_test.go
Comment thread internal/cmd/beta/security-group-rule/describe/describe_test.go
GokceGK and others added 12 commits December 10, 2024 08:46
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Comment thread internal/cmd/beta/security-group-rule/create/create_test.go
Comment thread internal/cmd/beta/security-group-rule/create/create_test.go Outdated
Fyusel
Fyusel previously approved these changes Dec 10, 2024
Comment thread internal/cmd/beta/security-group/rule/create/create.go Outdated
Comment thread internal/pkg/errors/errors.go Outdated
@GokceGK GokceGK merged commit 49589d5 into main Dec 12, 2024
@GokceGK GokceGK deleted the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
@GokceGK GokceGK restored the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
@GokceGK GokceGK deleted the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants