Skip to content

Add support for custom IDP endpoint and client ID#400

Merged
joaopalet merged 13 commits into
mainfrom
jp/idp-custom-endpoints
Jul 4, 2024
Merged

Add support for custom IDP endpoint and client ID#400
joaopalet merged 13 commits into
mainfrom
jp/idp-custom-endpoints

Conversation

@joaopalet
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread internal/pkg/auth/user_login.go Outdated
Comment thread internal/cmd/config/set/set.go
Comment thread internal/cmd/config/set/set.go Outdated
@DiogoFerrao
Copy link
Copy Markdown
Contributor

DiogoFerrao commented Jul 4, 2024

In general, I think we should document the process of configuring a custom IDP in a README file since its quite different from the others and could be complex.

Maybe this is the correct place to document the process, and then just refer the user to this guide in the flags, instead of cluttering the flag documentation

@joaopalet
Copy link
Copy Markdown
Contributor Author

In general, I think we should document the process of configuring a custom IDP in a README file since its quite different from the others and could be complex.

Maybe this is the correct place to document the process, and then just refer the user to this guide in the flags, instead of cluttering the flag documentation

I've added a bit more information to the flags description and have asked a colleague from the IDP for a suggestion on documentation to link.

I'm not sure the README is the right place to document these, but definitely having a page with more information about it makes sense. Maybe creating a page in the STACKIT KB?

Comment thread internal/pkg/auth/utils_test.go Outdated
@joaopalet joaopalet enabled auto-merge (squash) July 4, 2024 14:23
@joaopalet joaopalet merged commit b799e96 into main Jul 4, 2024
@joaopalet joaopalet deleted the jp/idp-custom-endpoints branch July 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants