Logging: update table.Display to use the print package#200
Merged
Conversation
DiogoFerrao
changed the title
vicentepinto98
approved these changes
Apr 8, 2024
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* switch prints to p.Info and p.Output * fix linting * address PR comments * change cmd.outstdout to p.outstdout
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* switch prints to p.Info and p.Output * fix linting * address PR comments * change cmd.outstdout to p.outstdout
DiogoFerrao
added a commit
that referenced
this pull request
Apr 8, 2024
* switch prints to p.Info and p.Output * fix linting * address PR comments * change cmd.outstdout to p.outstdout
DiogoFerrao
added a commit
that referenced
this pull request
Apr 9, 2024
* Add global verbosity flag (#178) * Implement new print package and integrate in first commands (#182) * Implement new print package * Integrate in first commands * Update all tests * Fix linter * Rename some consts and methods * Add debug logs in activate-service-account login * Add unit tests * Add one additional test case * Introduce p.Info and p.Output to log messages and command output (respectively) (#198) * switch prints to p.Info and p.Output * fix linting * remove remaining prints * update curl * more mapping fixes * address PR comments * Logging: update table.Display to use the print package (#200) * switch prints to p.Info and p.Output * fix linting * address PR comments * change cmd.outstdout to p.outstdout * Move confirmation prompt to Print package (#201) * Move confirmation prompt to Print package * Update confirmationPrompt signature, use p.Cmd * remove p.OutOrStdout, use cmd instead * Logging: change spinner to print package, update docs (#203) * change spinner to print package * generate docs * remove duplicate statements * Logging: move warnings to verbosity package (#209) * move warnings to verbosity package * Remove Warnf, change Warn and Error to Printf formatting * remove new line at the end of Warn output, callers have to add it themselves (printf behavior) --------- Co-authored-by: João Palet <joao.palet@outlook.com> Co-authored-by: vicentepinto98 <vicente.pinto@freiheit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the table.Display method to use the Printer.OutOrStdout method.
This means changing the signature of most outputResult methods from describe and list commands, since it no longer requires cmd.
With this PR, only the spinner and the confirmation prompt still rely on cmd to print.