CSI compatibility mode by ftl · Pull Request #175 · stackitcloud/gardener-extension-provider-stackit

ftl · 2026-06-12T07:35:52Z

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
This change allows to deploy two separate instances of the STACKIT CSI driver, on in "normal" mode, and the second one in "compatibility" mode. This is part of the migration from cinder to the STACKIT CSI driver.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This change requires the enhancement stackitcloud/cloud-provider-stackit#161 to be available in the cloud-provider-stackit CSI driver plugin.

Breaking changes:

ske-prow · 2026-06-12T07:35:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aniruddha2000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ccordingly

…esource Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

ftl · 2026-06-19T11:01:29Z

/test pull-gardener-extension-provider-stackit-verify

ftl · 2026-06-24T11:26:59Z

/test pull-gardener-extension-provider-stackit-verify

ftl · 2026-06-24T11:38:32Z

/test pull-gardener-extension-provider-stackit-verify

…n the seed control plane

ftl · 2026-06-25T10:09:20Z

/hold until stackitcloud/cloud-provider-stackit#161 is merged

…sion Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

…ifferent driverName Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

…y mode Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

compatibility driver

ManagedResource CRs are deployed

ske-prow · 2026-06-29T14:38:09Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dergeberl · 2026-07-02T11:47:36Z

@@ -1,3 +1,4 @@
+{{- if not .Values.csi.enableCompatibilityMode }}


Why do we dont deploy the PodDisruptionBudget when enable the CompatibilityMode

@dergeberl We only need one snapshot controller per cluster. It would just be duplicated doing nothing.

dergeberl · 2026-07-02T11:47:51Z

@@ -1,4 +1,4 @@
---
+{{- if not .Values.csi.enableCompatibilityMode }}


Why do we dont deploy the VerticalPodAutoscaler when enable the CompatibilityMode

Same as above. One snapshot-controller is suffice.

dergeberl · 2026-07-02T11:49:32Z

@@ -1,3 +1,4 @@
+{{- if not .Values.csi.enableCompatibilityMode }}


This is not needed as the snapshot-controller dont use the driverName right? Snapshots can be still created for both drivernames?

Yes, correct. The leader of the controller is also hard-coded so it wouldn't even bring you anything if you have multiple controllers running.

dergeberl · 2026-07-02T11:51:08Z

      annotations:
        checksum/configmap-cloud-provider-config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
-        node.gardener.cloud/wait-for-csi-node-stackit: block-storage.csi.stackit.cloud
+        {{- if eq .Values.driverName "cinder.csi.openstack.org" }}


We could use the enableCompatibilityMode instead if the driver here

Suggested change

{{- if eq .Values.driverName "cinder.csi.openstack.org" }}

{{- if .Values.csi.enableCompatibilityMode }}

It is then also needed to switch the annotations in the if/else

dergeberl · 2026-07-02T11:53:10Z

+	Name              string `json:"name"`
+	CompatibilityMode string `json:"compatibilityMode,omitempty"`


Can we add a description/comment here what this fields are and what the default is?

ske-prow · 2026-07-02T13:38:20Z

@ftl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gardener-extension-provider-stackit-verify	`5677f76`	link	true	`/test pull-gardener-extension-provider-stackit-verify`
pull-gardener-extension-provider-stackit-integration-tests	`5677f76`	link	true	`/test pull-gardener-extension-provider-stackit-integration-tests`

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ftl added 3 commits June 11, 2026 12:01

define the CompatibilityMode field

2aa5c46

add the default value for CSI.CompatibilityMode

34b1e30

provide access to the new CompatibilityMode field

b26aa99

ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 12, 2026

ftl marked this pull request as draft June 12, 2026 07:36

ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2026

render the second DaemonSet in compatibility mode, if parameterized a…

92697d7

…ccordingly

ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2026

nschad and others added 11 commits June 15, 2026 11:08

install control-plane stackit-blockstorage chart (compat) as ManagedR…

05cd918

…esource Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix chart path

3703159

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix chart path and releaseName

3c1fef4

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix path?

2f32d47

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

Move some things around

8dc17ef

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix values?

a03c8df

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix type assertion

4c59bcd

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

fix namespace

f46ef40

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

use different name for MR release

5d15fee

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

apply fixes and inject images manually

f6b0a54

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

remove the duplicated DaemonSet as it is not needed

c923b5d

ftl force-pushed the csi-compatibility-mode branch from 4fa0ce5 to c923b5d Compare June 17, 2026 07:28

ftl added 5 commits June 17, 2026 13:52

add a symmetric method for the Shoot controlplane in Compatibility Mode

96a59fd

use the correct image vector for the Shoot controlplane

00827ca

delete compatibility mode managed resources when not needed

5b71759

control the legacy-volume-creation flag

14e2fcc

make sure to use the correct namespace and origin

6f82793

ftl requested a review from maboehm June 19, 2026 08:26

ftl added 2 commits June 24, 2026 13:32

go mod tidy

e6f1909

modernize

d5cc0b4

ftl marked this pull request as ready for review June 24, 2026 11:39

ske-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026

nschad requested changes Jun 25, 2026

View reviewed changes

ftl added 2 commits June 25, 2026 11:15

move the legacy-volume-creation flag to the seed control plane

bcf30d3

use a different healthz port in the second csi drive instance, also i…

5d45900

…n the seed control plane

ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2026

ftl and others added 12 commits June 25, 2026 12:12

fix typo

2c876d0

use a better prefix

1dc86cd

fix: deploy seed part in correct namespace; findImage by specific ver…

4051952

…sion Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

make stackit-blockstorage-csi-driver (shoot) chart customizable for d…

64ca6f6

…ifferent driverName Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

make health-port of CSI livenessprobe configurable

d3e7c7a

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

only deploy snapshot-controller once

cfb6787

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

use the correct namespace

e966458

fix: deploy snapshotcontroller by default; but NOT if in compatibilit…

08f1015

…y mode Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

check the liveness-probe healthz port

2787b75

check the csi drive name in COMPAT(BLOCK) mode

913f3da

check that there is no snapshot controller deployed with the

c047568

compatibility driver

create an integration test that checks if the compatibility related

eef3bdd

ManagedResource CRs are deployed

ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2026

ske-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 29, 2026

dergeberl reviewed Jul 2, 2026

View reviewed changes

add test to cover the transition from compat to default

5677f76

		@@ -1,3 +1,4 @@
		{{- if not .Values.csi.enableCompatibilityMode }}

		@@ -1,4 +1,4 @@
		---
		{{- if not .Values.csi.enableCompatibilityMode }}

	{{- if eq .Values.driverName "cinder.csi.openstack.org" }}
	{{- if .Values.csi.enableCompatibilityMode }}

		Name string `json:"name"`
		CompatibilityMode string `json:"compatibilityMode,omitempty"`

Uh oh!

Conversation

ftl commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ske-prow Bot commented Jun 12, 2026

Uh oh!

ftl commented Jun 19, 2026

Uh oh!

ftl commented Jun 24, 2026

Uh oh!

ftl commented Jun 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ftl commented Jun 25, 2026

Uh oh!

ske-prow Bot commented Jun 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ske-prow Bot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ftl commented Jun 12, 2026 •

edited

Loading