Update module github.com/stackitcloud/stackit-sdk-go/services/iaas to v1.10.1 (main)#858
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f3d9268 to
eedc2e4
Compare
cfc1ac2 to
d1a7830
Compare
d1a7830 to
748bd44
Compare
748bd44 to
2a5be4d
Compare
90f503e to
195b8a3
Compare
f407ae2 to
8afa999
Compare
8afa999 to
4cb9401
Compare
4cb9401 to
25b1c29
Compare
25b1c29 to
f6b5c13
Compare
f6b5c13 to
43d8c3e
Compare
43d8c3e to
6d8bcea
Compare
6d8bcea to
c5806ec
Compare
c5806ec to
cc7512f
Compare
cc7512f to
e471a17
Compare
e471a17 to
c2375c2
Compare
c2375c2 to
05da254
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
9016795 to
a475b82
Compare
|
tested in ondemand with kubernetes version 1.34. tested volume creation + deletion via stackit CSI |
a475b82 to
ab40fc9
Compare
| nics := server.GetNics() | ||
| for i := range nics { | ||
| nic := nics[i] |
There was a problem hiding this comment.
Hat was the reason for not do this:
| nics := server.GetNics() | |
| for i := range nics { | |
| nic := nics[i] | |
| for _, nic := range server.GetNics() { |
| for i := range serverList { | ||
| server := serverList[i] | ||
| if serverName, ok := server.GetNameOk(); ok && serverName == name { | ||
| if serverName, ok := server.GetNameOk(); ok && serverName != nil && *serverName == name { |
There was a problem hiding this comment.
This should also work and is better to read.
GetName() returns a empty string in case none is set.
| if serverName, ok := server.GetNameOk(); ok && serverName != nil && *serverName == name { | |
| if server.GetName() == name { |
| if ipv4, ok := nic.GetIpv4Ok(); ok && ipv4 != nil { | ||
| addToNodeAddresses(&addresses, | ||
| corev1.NodeAddress{ | ||
| Address: ipv4, | ||
| Address: *ipv4, | ||
| Type: corev1.NodeInternalIP, | ||
| }) | ||
| } |
There was a problem hiding this comment.
In theory the nil check is not needed, if the value is nil, ok is false.
// GetIpv4Ok returns a tuple with the Ipv4 field value if set, nil otherwise
// and a boolean to check if the value has been set.
func (o *ServerNetwork) GetIpv4Ok() (*string, bool) {
if o == nil || IsNil(o.Ipv4) {
return nil, false
}
return o.Ipv4, true
}
But we also could use:
| if ipv4, ok := nic.GetIpv4Ok(); ok && ipv4 != nil { | |
| addToNodeAddresses(&addresses, | |
| corev1.NodeAddress{ | |
| Address: ipv4, | |
| Address: *ipv4, | |
| Type: corev1.NodeInternalIP, | |
| }) | |
| } | |
| if nic.HasIpv4() { | |
| addToNodeAddresses(&addresses, | |
| corev1.NodeAddress{ | |
| Address: nic.GetIpv4(), | |
| Type: corev1.NodeInternalIP, | |
| }) | |
| } |
| } | ||
|
|
||
| if ipv6, ok := nic.GetIpv6Ok(); ok { | ||
| if ipv6, ok := nic.GetIpv6Ok(); ok && ipv6 != nil { |
There was a problem hiding this comment.
| } | ||
|
|
||
| if publicIP, ok := nic.GetPublicIpOk(); ok { | ||
| if publicIP, ok := nic.GetPublicIpOk(); ok && publicIP != nil { |
There was a problem hiding this comment.
|
/cherry-pick release-v1.33 |
|
@breuerfelix: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR contains the following updates:
v1.3.5→v1.10.1Release Notes
stackitcloud/stackit-sdk-go (github.com/stackitcloud/stackit-sdk-go/services/iaas)
v1.10.1Compare Source
v1.10.0Compare Source
v1.9.2Compare Source
v1.9.1Compare Source
v1.9.0Compare Source
v1.8.2Compare Source
v1.8.1Compare Source
v1.8.0Compare Source
v1.7.1Compare Source
v1.7.0Compare Source
v1.6.0Compare Source
v1.5.1Compare Source
v1.5.0Compare Source
v1.4.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.